Re: Re: Patches from Robert Millan

On Monday 30 July 2007 14:20, Julian Mehnle wrote:
> Magnus Holmgren wrote:
> > I suggest that this logic
> >
> > 	if (sr->env_from == NULL)
> > 		SPF_request_set_env_from(sr, dom);
> >
> > be moved from SPF_request_set_helo_dom() to SPF_request_set_env_from().
>
> But then, within SPF_request_set_env_from(), where would you get "dom" (the
> HELO domain) from?  Right, you'd use the value set by a prior call to
> SPF_request_set_helo_dom().  But then users would be required to call
> SPF_request_set_helo_dom() _first_, and SPF_request_set_env_from()
> _second_.
>
> Perhaps the above logic could be _copied_ to SPF_request_set_env_from()
> rather than _moved_?

Perhaps. It's would still be more localized that way than if checking for an 
empty domain in numerous places, and localized is a Good Thing.

-- 
Magnus Holmgren        [email protected]
                       (No Cc of list mail needed, thanks)

-------------------------------------------
-----------------------------------------------------------------------
To unsubscribe, change your address, or temporarily deactivate your
subscription,
please go to http://v2.listbox.com/member/?member_id=6959932&id_secret=26480375-eed91e
Powered by Listbox: http://www.listbox.com

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBGrdlQk7mRNn1h4+YRApZnAKCfB5SjV1ktJ0nTkhvqn0XkIgZkDwCgxCy8
0/X67Ip8em20dOIiEgeD3NQ=
=pccR
-----END PGP SIGNATURE-----