Re: Bug in digest_md5_parse_challenge

[email protected]
Newsgroups gmane.mail.squirrelmail.devel
Message-ID <[email protected]>
    Paul> Please make sure to state the version you are using.  Looks
    Paul> like you are using 1.5.2SVN

Yes, it's that version.

    Paul> also used in our stable branch, so..... can you please
    Paul> replace that line with the following and confirm no notices
    Paul> occur?

Well, it's solved with !=, not with !==. I attach the little patch to
this mail.

    Paul> Unified diffs are best, sent to this list or submitted to
    Paul> our sf.net tracker.

I've generated it with "svn diff -x -ub", that generate an unified patch.

Regards

-- 
    Pablo Álvarez de Sotomayor Posadillo
Ingeniero Técnico en Informática de Sistemas
	    http://ritho.net
 "De todas las cosas que he perdido la que 
     mas hecho de menos es mi cerebro"

===File ~/auth_digest_md5_warning.patch=====================
Index: functions/auth.php
===================================================================
--- functions/auth.php	(revision 13262)
+++ functions/auth.php	(working copy)
@@ -199,7 +199,7 @@
  */
 function digest_md5_parse_challenge($challenge) {
     $challenge=base64_decode($challenge);
-    while (isset($challenge) && $challenge !== FALSE) {
+    while (isset($challenge) && $challenge != FALSE) {
         if ($challenge{0} == ',') { // First char is a comma, must not be 1st time through loop
             $challenge=substr($challenge,1);
         }
============================================================

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: [email protected]
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.