Re: Bug in digest_md5_parse_challenge

On Sat, Aug 16, 2008 at 4:51 PM,  <[email protected]> wrote:
>
>    Paul> Please make sure to state the version you are using.  Looks
>    Paul> like you are using 1.5.2SVN
>
> Yes, it's that version.
>
>    Paul> also used in our stable branch, so..... can you please
>    Paul> replace that line with the following and confirm no notices
>    Paul> occur?
>
> Well, it's solved with !=, not with !==. I attach the little patch to
> this mail.

If base64_decode() returns FALSE, then !== should catch it.  Can you
explain why !== does not work?

>    Paul> Unified diffs are best, sent to this list or submitted to
>    Paul> our sf.net tracker.
>
> I've generated it with "svn diff -x -ub", that generate an unified patch.
>
> ===File ~/auth_digest_md5_warning.patch=====================
> Index: functions/auth.php
> ===================================================================
> --- functions/auth.php  (revision 13262)
> +++ functions/auth.php  (working copy)
> @@ -199,7 +199,7 @@
>  */
>  function digest_md5_parse_challenge($challenge) {
>     $challenge=base64_decode($challenge);
> -    while (isset($challenge) && $challenge !== FALSE) {
> +    while (isset($challenge) && $challenge != FALSE) {
>         if ($challenge{0} == ',') { // First char is a comma, must not be 1st time through loop
>             $challenge=substr($challenge,1);
>         }
> ============================================================

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: [email protected]
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel