Re: Removing \M-s binding
Greg Bognar <[email protected]> Wed, 24 Jul 2019 18:51:44 +0200
| Newsgroups | gmane.mail.wanderlust.general |
|---|---|
| Message-ID | <87sgqvs7dr.wl-greg.bognar__41075.3549354681$1563987206$gmane$org@startmail.com> |
On Wed 24 Jul 2019 at 16:53 Ken Gunderson wrote: > > > > Relatedly, \M-s is bound to wl-summary-stick (a very useful command) in > > > > wl-summary-mode-map. If WL's bindings should not override Emacs's > > > > general bindings (and I think they shouldn't), perhaps that binding > > > > should be changed too. > > > > > > You are right except the case Wanderlust intendedly override. The point > > > is that which key should be bound to wl-summary-stick. If there is no > > > suggestion, I'm going to bind M-S to wl-summary-stick. > > > > M-S is the same as M-s, so that still overrides Emacs's search-map > > binding. s and S are already bound. > > > > What about +? + is currently not bound in wl-summary-mode-map, and it is > > sort of an obvious choice. > > Seems strange to me. M-s is undefined on a freshly launched Emacs, M-s is a global prefix key in vanilla Emacs. It is bound to search-map in bindings.el. (M-x apropos-variable RET search-map RET) E.g., M-s o is occur, M-s w is isearch-forward-word, M-s h is itself a prefix for hi-lock's commands. > sans any modes, unless I am in Wanderlust and in Summary buffer, in wh/case > both M-s and M-S offer to stick summary buffer. Makes total sense to me. I > don't understand the issue here? Packages should not override default Emacs bindings. I discovered the issue when I wanted to run occur from a Summary buffer, and didn't understand why the usual keybinding did not work. Similarly, isearch-forward-word or hi-lock can be useful in a Summary buffer. Standard keybindings should work as expected by the user. In the Summary buffer, most commands are unmodified anyway. In the Folder buffer M-s is redundant. If I'm not mistaken, the M-s binding is a somewhat recent addition to Emacs, so Wanderlust might have had its M-s bindings first. All the best, Greg