Re: Session Greeting Message Format

Rajesh Madabhushi <[email protected]> writes:

> Hi,
> 
> Is it required to terminate 'greeting' element, exchanged during
> session establishment, with CR LF ?  I think in each line of  BEEP
> Payload must terminate CR LF.
> 
> For example greeting element must be something looks like
> "<greeting>\r\n<profile uri='http://iana.org/beep/TLS'
> />\r\n</greeting>\r\n" for TLS Profile.
> 
> But in the current implementation of RoadRunner Core, greeting message
> header is just terminated with '\n' instead of '\r\n'. Is it correct ?
> 
Are you sure? take a look at line 222 in rr-greeting.c. Or run

/usr/sbin/tcpdump -i lo -X -s 65535  'port 10289'

13:10:24.907780 localhost.10289 > localhost.36012: P 1:197(196) ack 1 
win 32767 <nop,nop,timestamp 24520105 24520105> (DF)
0x0000   4500 00f8 8de9 4000 4006 ae14 7f00 0001        E.....@.@.......
0x0010   7f00 0001 2831 8cac 8aad a840 8a78 21ac        ....([email protected]!.
0x0020   8018 7fff 2ccc 0000 0101 080a 0176 25a9        ....,........v%.
0x0030   0176 25a9 5250 5920 3020 3020 2e20 3020        .v%.RPY.0.0...0.
0x0040   3137 340d 0a43 6f6e 7465 6e74 2d54 7970        174..Content-Typ
0x0050   653a 2061 7070 6c69 6361 7469 6f6e 2f62        e:.application/b
0x0060   6565 702b 786d 6c0d 0a0d 0a3c 6772 6565        eep+xml....<gree
0x0070   7469 6e67 3e0a 2020 203c 7072 6f66 696c        ting>....<profil
0x0080   6520 7572 693d 2768 7474 703a 2f2f 786d        e.uri='http://xm
0x0090   6c2e 7265 736f 7572 6365 2e6f 7267 2f70        l.resource.org/p
0x00a0   726f 6669 6c65 732f 4e55 4c4c 2f45 4348        rofiles/NULL/ECH
0x00b0   4f27 202f 3e0d 0a20 2020 3c70 726f 6669        O'./>.....<profi
0x00c0   6c65 2075 7269 3d27 6874 7470 3a2f 2f69        le.uri='http://i
0x00d0   616e 612e 6f72 672f 6265 6570 2f54 4c53        ana.org/beep/TLS
0x00e0   2720 2f3e 0d0a 3c2f 6772 6565 7469 6e67        './>..</greeting
0x00f0   3e0d 0a45 4e44 0d0a                            >..END..

/ Jonas
-- 
Jonas Borgström                  [email protected]
CodeFactory AB                   http://www.codefactory.se/
Office: +46 (0)90 71 86 10       Cell: +46 (0)70 248 89 58