3C90X_BOOTROM_FIX does not compile

Anders Larsen <[email protected]> Sun, 02 Apr 2006 22:27:03 +0200
Newsgroups gmane.network.etherboot.user,gmane.network.etherboot.devel
Organization systems engineer Anders Larsen
Message-ID <[email protected]>
Hi,

I just tried to build etherboot 5.4.1 for an old 3c905B card.
This card has a quirk in that not all address lines are enabled to
the eprom socket by default (as documented in 3c90x.txt).

Unfortunately, the driver does not compile with CFG_3C90X_BOOTROM_FIX
defined, as the necessary helpers in 3c90x.c have been commented out.

The patch below (against current CVS) trivially fixes this.

Signed-off-by: Anders Larsen <[email protected]>

Index: 3c90x.c
===================================================================
RCS file: /cvsroot/etherboot/etherboot/etherboot-5.4/src/drivers/net/3c90x.c,v
retrieving revision 1.2
diff -u -u -r1.2 3c90x.c
--- 3c90x.c	31 Aug 2005 12:35:40 -0000	1.2
+++ 3c90x.c	2 Apr 2006 20:17:05 -0000
@@ -319,7 +319,7 @@
     }
 
 
-#if 0
+#ifdef	CFG_3C90X_BOOTROM_FIX
 /*** a3c90x_internal_WriteEepromWord - write a physical word of
  *** data to the onboard serial eeprom (not the BIOS prom, but the
  *** nvram in the card that stores, among other things, the MAC
@@ -355,7 +355,7 @@
     }
 #endif
 
-#if 0
+#ifdef	CFG_3C90X_BOOTROM_FIX
 /*** a3c90x_internal_WriteEeprom - write data to the serial eeprom,
  *** and re-compute the eeprom checksum.
  ***/





-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642