Re: ebnc & ChangeLog
Karine Proot <[email protected]> Sun, 16 May 2004 10:35:43 +0200
| Newsgroups | gmane.network.everybuddy.devel |
|---|---|
| Message-ID | <1084696543.2706.6.camel@gelydh> |
On Sun, 2004-05-16 at 04:10, A. Craig West wrote: > Oops, I forgot about that case, but I'm not convinced your fix will do it > entirely... For one thing, your patch is assuming that there are status > messages only when away, which is certainly not true in Yahoo, at least. > Also, seeing as the statusString is a copy, the condition you are checking > for, statusString being NULL, won't happen. I assume too much every day. Bad habit I should quit. Though the patch worked for me, I agree I did not do it as elegantly as you. > The problem you are trying to deal with in the 'special case' code is tough > to detect, actually. Here is an implementation that is base on keeping track > of which account we have the status from, instead of the status itself. This > gives us much better flexibility for detecting things like this... Thanks, applied. I also added a ChangeLog at last. I don't know if I'm theonly heretic using emacs and syntaxic coloration, but beloved penguin of mine showed me the standard for ChangeLog and now it looks beautiful in my editor (as I keep svn commit messages and ChangeLog entries identical, only the latest entry is really perfect ;)) Karine (that's what girliez are for: annoying you with colors)