ebnc

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.
  Send mail to [email protected] for more info.

---1463811291-1792110935-1084830122=:8785
Content-Type: TEXT/PLAIN; charset=US-ASCII

I have found an odd bug in the display of names for the buddy chat windows
in ebnc. The problem seems to be caused when we close one of the chat
windows, we don't seem to properly update the actual WINDOW* of the tabs on
the left side of the screen. As far as I can tell, the TabWinList::removeTab
method should call wclear and waddstr with the new tab name when we are
reassigning tabs after a deletion. I haven't quite got it working properly
on my machine, though. Hopefully Karine knows what is going on in there
better and can make it work properly :-)
To duplicate it, get a bunch of conversations going, then close some of them,
particularly NOT the last one. Then watch as the buddies atached to the
conversations status changes. You should notice various things such as tabs
drawing with blank names, and status changes updating the wrong tab. As to
how to fix it, I thought I knew how, but I seem to have been wrong.
Just looking at the code, I figured out what I forgot... The Tabs are keeping
track of their window in currentWin, but this value is never being updated
when you move tabs around...
I have a patch that does the job, now that I found that...

-- 
Craig West         Ph: (416) 666-1645	|  It's not a bug,
[email protected]              	|  It's a feature...
---1463811291-1792110935-1084830122=:8785
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="ebnc.patch"
Content-Transfer-Encoding: BASE64
Content-ID: <[email protected]>
Content-Description: patch for buddy tabs
Content-Disposition: attachment; filename="ebnc.patch"

SW5kZXg6IHdpbmRvd3MuaA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0t
IHdpbmRvd3MuaAkocmV2aXNpb24gMzYyKQ0KKysrIHdpbmRvd3MuaAkod29y
a2luZyBjb3B5KQ0KQEAgLTc4LDYgKzc4LDcgQEANCiAgIHZvaWQgc2V0UHJl
dmlvdXMoVGFiICp0KTsNCiAgIHZvaWQgc2V0TmV4dChUYWIgKnQpOw0KICAg
dm9pZCBzZXRBY3Rpdml0eShpbnQgYWN0aXZpdHkpOw0KKyAgdm9pZCBzZXRD
dXJyZW50V2luKFdJTkRPVyAqY3VycmVudFdpbik7DQogIHByaXZhdGU6DQog
ICBUYWIgKnByZXZpb3VzOw0KICAgVGFiICpuZXh0Ow0KSW5kZXg6IHdpbmRv
d3MuY3BwDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gd2luZG93cy5j
cHAJKHJldmlzaW9uIDM2MikNCisrKyB3aW5kb3dzLmNwcAkod29ya2luZyBj
b3B5KQ0KQEAgLTI2MCw2ICsyNjAsMTEgQEANCiAgIH0NCiB9DQogDQordm9p
ZCBUYWI6OnNldEN1cnJlbnRXaW4oV0lORE9XICpjdXJyZW50V2luKQ0KK3sN
CisgIHRoaXMtPmN1cnJlbnRXaW4gPSBjdXJyZW50V2luOw0KK30NCisNCiAv
KioqIENoYXRUYWIgKioqLw0KIA0KIENoYXRUYWI6OkNoYXRUYWIoV0lORE9X
ICpjdXJyZW50V2luLCBjaGFyICpuYW1lLCBpbnQgdHlwZSkNCkBAIC00MTYs
MTIgKzQyMSwyNSBAQA0KIHsNCiAgIC8vdDIgaXMgdGhlIGZpcnN0IHRhYiB1
bnNlZW4gYmVmb3JlIHJlbW92YWwgKE5VTEwgaWYgYWxsIHRhYnMgd2VyZSBv
biBzY3JlZW4pDQogICBpbnQgaSA9IGdldEluZGV4KHQpOw0KLSAgd2NsZWFy
KHRhYldpbnNbaV0pOw0KICAgaWYgKGkgPiAtMSkNCiAgIHsNCiAgICAgZm9y
IChpbnQgaj1pOyBqIDwgbnVtYmVyLTE7IGorKykNCisgICAgew0KKyAgICAg
IHdjbGVhcih0YWJXaW5zW2pdKTsNCiAgICAgICB0YWJzW2pdID0gdGFic1tq
KzFdOw0KKyAgICAgIGlmICh0YWJzW2pdKQ0KKyAgICAgIHsNCisJdGFic1tq
XS0+c2V0Q3VycmVudFdpbih0YWJXaW5zW2pdKTsNCisgICAgICAgIG12d2Fk
ZHN0cih0YWJXaW5zW2pdLCAwLCAwLCB0YWJzW2pdLT5nZXRTaG9ydE5hbWUo
KSk7DQorICAgICAgfQ0KKyAgICB9DQorICAgIHdjbGVhcih0YWJXaW5zW251
bWJlci0xXSk7DQogICAgIHRhYnNbbnVtYmVyLTFdID0gdDI7DQorICAgIGlm
ICh0YWJzW251bWJlci0xXSkNCisgICAgew0KKyAgICAgIHRhYnNbbnVtYmVy
LTFdLT5zZXRDdXJyZW50V2luKHRhYldpbnNbbnVtYmVyLTFdKTsNCisgICAg
ICBtdndhZGRzdHIodGFiV2luc1tudW1iZXItMV0sIDAsIDAsIHRhYnNbbnVt
YmVyLTFdLT5nZXRTaG9ydE5hbWUoKSk7DQorICAgIH0NCiAgIH0NCiB9DQog
DQo=

---1463811291-1792110935-1084830122=:8785
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Everybuddy-Dev mailing list
[email protected]
http://lists.spine.cx/listinfo/everybuddy-dev

---1463811291-1792110935-1084830122=:8785--