Re: yahoo plugin, take II

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.
  Send mail to [email protected] for more info.

---1463811291-1030253283-1084855611=:1020
Content-Type: TEXT/PLAIN; charset=US-ASCII

On Fri, 14 May 2004, A. Craig West wrote:

> On Thu, 13 May 2004, A. Craig West wrote:
> 
> > It turns out that the yahoo plugin is also subject to the same bug as the toc
> > one had, it was just a lot rarer. Patch is attached...
> 
> I did, however, get it wrong, that's why I keep testing these things :-)
> I also added some fflush calls to get the output to actually output.

The joys of being your own beta tester... libyahoo2, as cuurently written,
returns the same error code for an unsuccessful connection as for a socket
closed by the server later. It turns out that we need to be able to
differentiate those two cases. This patch does that, now, and I will propogate
the relevant changes over to libyahoo2, seeing as I can :-) It seems like a
useful distinction to make...

-- 
Craig West         Ph: (416) 666-1645	|  It's not a bug,
[email protected]              	|  It's a feature...
---1463811291-1030253283-1084855611=:1020
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="yahoo.patch"
Content-Transfer-Encoding: BASE64
Content-ID: <[email protected]>
Content-Description: try again
Content-Disposition: attachment; filename="yahoo.patch"

SW5kZXg6IGNvcmUvcGx1Z2lucy95YWhvby95YWhvby5jDQo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09DQotLS0gY29yZS9wbHVnaW5zL3lhaG9vL3lhaG9vLmMJ
KHJldmlzaW9uIDM2MikNCisrKyBjb3JlL3BsdWdpbnMveWFob28veWFob28u
Ywkod29ya2luZyBjb3B5KQ0KQEAgLTM5MCw2ICszOTAsNyBAQA0KIHsNCiAg
IEVMaXN0ICogc3RhdGVzID0gTlVMTDsNCiAgIHByaW50ZigiSGktaG8sIGhp
LWhvLCBZYWhvbyBoZXJlIHdlIGdvIVxuIik7DQorICBmZmx1c2goc3Rkb3V0
KTsNCiAgIC8qeWFob29fc2V0X2xvZ19sZXZlbChZQUhPT19MT0dfREVCVUcp
OyovDQogDQogICBtZW1zZXQoJnlhaG9vX2NhbGxiYWNrcywgMCwgc2l6ZW9m
KHlhaG9vX2NhbGxiYWNrcykpOw0KQEAgLTQ0OSwxMyArNDUwLDMxIEBADQog
ICBpZiAobGEgPT0gTlVMTCkNCiAgIHsNCiAgICAgcHJpbnRmKCJNYXJ0aWFu
IFlhaG9vIGNvbm5lY3Rpb25cbiIpOw0KKyAgICBmZmx1c2goc3Rkb3V0KTsN
CiAgICAgcmV0dXJuOw0KICAgfQ0KIA0KICAgc3dpdGNoIChzdWNjKQ0KICAg
ew0KKyAgICBjYXNlIFlBSE9PX0xPR0lOX1NPQ0s6DQorICAgIHsNCisgICAg
ICBpZiAobGEtPnJlYWR5KQ0KKyAgICAgIHsNCisJcHJpbnRmKCJCYWQgWWFo
b28gY29ubmVjdGlvbiBidXQgYWxyZWFkeSB2YWxpZCwgbXVzdCBiZSBzdGFs
ZVxuIik7DQorCWZmbHVzaChzdGRvdXQpOw0KKwlyZXR1cm47DQorICAgICAg
fQ0KKyAgICAgIGxvZ291dChsYSk7DQorICAgICAgYnJlYWs7DQorICAgIH0N
CiAgICAgY2FzZSBZQUhPT19MT0dJTl9PSzoNCiAgICAgew0KKyAgICAgIGlm
IChsYS0+cmVhZHkpDQorICAgICAgew0KKwlwcmludGYoIlJlZHVuZGFudCBZ
YWhvbyBjb25uZWN0aW9uXG4iKTsNCisJZmZsdXNoKHN0ZG91dCk7DQorCXJl
dHVybjsNCisgICAgICB9DQogICAgICAgbGEtPnJlYWR5ID0gMTsNCiAgICAg
ICBmcmVlKGxhLT5zdGF0dXNfc3RyaW5nKTsNCiAgICAgICBsYS0+c3RhdHVz
X3N0cmluZyA9IHN0cmR1cChHRVRfTEFEKGxhKS0+aW52aXNpYmxlID8gIklu
dmlzaWJsZSIgOiAiT25saW5lIik7DQpAQCAtNDY0LDkgKzQ4MywxMSBAQA0K
ICAgICBjYXNlIFlBSE9PX0xPR0lOX0RVUEw6DQogICAgIHsNCiAgICAgICBw
cmludGYoIllhaG9vIGZvcmNlZCBvZmZsaW5lIGJ5IGR1cGxpY2F0ZSBsb2dp
blxuIik7DQorICAgICAgZmZsdXNoKHN0ZG91dCk7DQogICAgICAgbG9nb3V0
KGxhKTsNCiAgICAgICBicmVhazsNCiAgICAgfQ0KKyAgICBjYXNlIFlBSE9P
X1NPQ0tfRVJSOg0KICAgICBkZWZhdWx0Og0KICAgICB7DQogICAgICAgY2hh
ciBidWZbNTEyXTsNCkBAIC00NzQsNyArNDk1LDggQEANCiAgICAgICBzcHJp
bnRmKGJ1ZiwgIkRpc2Nvbm5lY3RlZCBmcm9tIHRoZSBZYWhvbyBuZXR3b3Jr
IC0gZXJyb3IgY29kZSAlZCIsIHN1Y2MpOw0KICAgICAgIGViX3Nob3dfZXJy
b3IoYnVmLCAiWWFob28gZXJyb3IiKTsNCiAgICAgICBsb2dvdXQobGEpOw0K
LSAgICAgIHByaW50ZigiTG9naW4gZXJyb3IgJWQgZm9yICVzIChZYWhvbyBp
ZCAlZClcbiIsIHN1Y2MsIGxhLT5oYW5kbGUsIGlkKTsgZmZsdXNoKHN0ZG91
dCk7DQorICAgICAgcHJpbnRmKCJMb2dpbiBlcnJvciAlZCBmb3IgJXMgKFlh
aG9vIGlkICVkKVxuIiwgc3VjYywgbGEtPmhhbmRsZSwgaWQpOw0KKyAgICAg
IGZmbHVzaChzdGRvdXQpOw0KICAgICB9DQogICB9DQogICBlYl9sb2NhbF9h
Y2NvdW50X3VwZGF0ZShsYSk7DQpAQCAtNTAwLDYgKzUyMiw3IEBADQogICBp
ZiAobGEgPT0gTlVMTCkNCiAgIHsNCiAgICAgcHJpbnRmKCJHb3QgYnVkZGll
cyBvbiBhIG1hcnRpYW4gYWNjb3VudCFcbiIpOw0KKyAgICBmZmx1c2goc3Rk
b3V0KTsNCiAgICAgcmV0dXJuOw0KICAgfQ0KICAgDQpAQCAtNTUwLDcgKzU3
MywxNCBAQA0KICAqLw0KIHZvaWQgZXh0X3lhaG9vX2dvdF9pZ25vcmUoaW50
IGlkLCBZTGlzdCAqIGlnbnMpDQogew0KKyAgWUxpc3QqIG47DQogICBwcmlu
dGYoIllhaG9vIGlnbm9yZSBsaXN0IGRvd25sb2FkZWQgT0suIFNoYW1lIHdl
IGRvbid0IGRvIGFueXRoaW5nIHdpdGggaXRcbnlldCwgcmVhbGx5LlxuIik7
DQorICBmb3IgKG4gPSBpZ25zOyBuICE9IE5VTEw7IG4gPSBuLT5uZXh0KQ0K
KyAgew0KKyAgICBzdHJ1Y3QgeWFob29fYnVkZHkgKiB5YiA9IChzdHJ1Y3Qg
eWFob29fYnVkZHkgKiluLT5kYXRhOw0KKyAgICBwcmludGYoIgklc1xuIiwg
eWItPmlkKTsNCisgIH0NCisgIGZmbHVzaChzdGRvdXQpOw0KIH0NCiANCiAN
CkBAIC01NjYsNyArNTk2LDE0IEBADQogICovDQogdm9pZCBleHRfeWFob29f
Z290X2lkZW50aXRpZXMoaW50IGlkLCBZTGlzdCAqIGlkcykNCiB7DQorICBZ
TGlzdCogbjsNCiAgIHByaW50ZigiSWRlbnRpdGllcyBkb3dubG9hZGVkXG4i
KTsNCisgIGZvciAobiA9IGlkczsgbiAhPSBOVUxMOyBuID0gbi0+bmV4dCkN
CisgIHsNCisgICAgY2hhciAqIGlkID0gKGNoYXIgKikgbi0+ZGF0YTsNCisg
ICAgcHJpbnRmKCIJJXNcbiIsIGlkKTsNCisgIH0NCisgIGZmbHVzaChzdGRv
dXQpOw0KIH0NCiANCiANCkBAIC01ODIsNiArNjE5LDcgQEANCiB2b2lkIGV4
dF95YWhvb19nb3RfY29va2llcyhpbnQgaWQpDQogew0KICAgcHJpbnRmKCJN
bW1tLCBjb29raWVzXG4iKTsNCisgIGZmbHVzaChzdGRvdXQpOw0KIH0NCiAN
CiANCkBAIC02MDcsNiArNjQ1LDcgQEANCiAgIGlmIChsYSA9PSBOVUxMKQ0K
ICAgew0KICAgICBwcmludGYoIk1hcnRpYW4gWWFob28gY29ubmVjdGlvblxu
Iik7DQorICAgIGZmbHVzaChzdGRvdXQpOw0KICAgICByZXR1cm47DQogICB9
DQogICBhY2MgPSBlYl9nZXRfYWNjb3VudChsYS0+aGFuZGxlLCAiWWFob28i
LCB3aG8pOw0KQEAgLTcyOSw2ICs3NjgsNyBAQA0KICAgaWYgKGxhID09IE5V
TEwpDQogICB7DQogICAgIHByaW50ZigiTWFydGlhbiBZYWhvbyBjb25uZWN0
aW9uXG4iKTsNCisgICAgZmZsdXNoKHN0ZG91dCk7DQogICAgIHJldHVybjsN
CiAgIH0NCiAgIGFjYyA9IGViX2dldF9hY2NvdW50KGxhLT5oYW5kbGUsICJZ
YWhvbyIsIHdobyk7DQpAQCAtOTk1LDYgKzEwMzUsNyBAQA0KIHZvaWQgZXh0
X3lhaG9vX3R5cGluZ19ub3RpZnkoaW50IGlkLCBjaGFyICp3aG8sIGludCBz
dGF0KQ0KIHsNCiAgIHByaW50ZigiJXMgaGFzICVzZWQgdHlwaW5nXG4iLCB3
aG8sIHN0YXQgPyAic3RhcnQiIDogInN0b3AiKTsNCisgIGZmbHVzaChzdGRv
dXQpOw0KIH0NCiANCiANCkBAIC0xMDI5LDYgKzEwNzAsNyBAQA0KICAgaWYg
KGxhID09IE5VTEwpDQogICB7DQogICAgIHByaW50ZigiTWFydGlhbiBZYWhv
byBjb25uZWN0aW9uXG4iKTsNCisgICAgZmZsdXNoKHN0ZG91dCk7DQogICAg
IHJldHVybjsNCiAgIH0NCiANCkBAIC0xMDk5LDYgKzExNDEsNyBAQA0KIAkJ
dW5zaWduZWQgaW50IHRpbWVzdGFtcCkNCiB7DQogICBwcmludGYoIldlZWVi
Y2FtIVxuIik7DQorICBmZmx1c2goc3Rkb3V0KTsNCiB9DQogDQogDQpAQCAt
MTExNCw2ICsxMTU3LDcgQEANCiB2b2lkIGV4dF95YWhvb193ZWJjYW1faW52
aXRlKGludCBpZCwgY2hhciAqZnJvbSkNCiB7DQogICBwcmludGYoIiVzIHdv
dWxkIGxpa2UgdG8gdmlldyB5b3VyIHdlYmNhbVxuIiwgZnJvbSk7DQorICBm
Zmx1c2goc3Rkb3V0KTsNCiB9DQogDQogDQpAQCAtMTEzMCw2ICsxMTc0LDcg
QEANCiB2b2lkIGV4dF95YWhvb193ZWJjYW1faW52aXRlX3JlcGx5KGludCBp
ZCwgY2hhciAqZnJvbSwgaW50IGFjY2VwdCkNCiB7DQogICBwcmludGYoIiVz
IGhhcyAlc2VkIHlvdXIgd2ViY2FtIHJlcXVlc3RcbiIsIGZyb20sIGFjY2Vw
dCA/ICJhY2NlcHQiIDogInJlamVjdCIpOw0KKyAgZmZsdXNoKHN0ZG91dCk7
DQogfQ0KIA0KIA0KQEAgLTExNDksNiArMTE5NCw3IEBADQogdm9pZCBleHRf
eWFob29fd2ViY2FtX2Nsb3NlZChpbnQgaWQsIGNoYXIgKndobywgaW50IHJl
YXNvbikNCiB7DQogICBwcmludGYoIldlYmNhbSBjb25uZWN0aW9uIHRvICVz
IGNsb3NlZCAoY29kZSAlZClcbiIsIHdobywgcmVhc29uKTsNCisgIGZmbHVz
aChzdGRvdXQpOw0KIH0NCiANCiANCkBAIC0xMTg1LDYgKzEyMzEsNyBAQA0K
ICAgaWYgKGxhID09IE5VTEwpDQogICB7DQogICAgIHByaW50ZigiRXJyb3Ig
b24gbWFydGlhbiBZYWhvbyBhY2N0XG4iKTsNCisgICAgZmZsdXNoKHN0ZG91
dCk7DQogICAgIHJldHVybjsNCiAgIH0NCiANCkBAIC0xMjQ4LDYgKzEyOTUs
NyBAQA0KICAgdmFfc3RhcnQoYXAsIGZtdCk7DQogICByPXZwcmludGYoZm10
LCBhcCk7DQogICB2YV9lbmQoYXApOw0KKyAgZmZsdXNoKHN0ZG91dCk7DQog
ICByZXR1cm4gcjsNCiB9DQogDQpAQCAtMTQwMiw3ICsxNDUwLDcgQEANCiAg
IGQtPmRvbmUgPSAwOw0KICAgcnZhbCA9IGViX2Nvbm5lY3Rfc29ja2V0KGhv
c3QsIHBvcnQsIGNvbm5fY2IsIGQpOw0KICAgaWYgKGQtPmRvbmUgJiYgcnZh
bCA+IDApDQotICAgIHJldHVybiAwOyAvLyBTdWNjZXNzZnVsLCBidXQgY2Fs
bGJhY2sgaGFzIGFscmVhZHkgYmVlbiBjYWxsZWQNCisgICAgcmV0dXJuIDA7
IC8qIFN1Y2Nlc3NmdWwsIGJ1dCBjYWxsYmFjayBoYXMgYWxyZWFkeSBiZWVu
IGNhbGxlZCAqLw0KICAgcmV0dXJuIHJ2YWw7DQogfQ0KIA0KSW5kZXg6IGNv
cmUvcGx1Z2lucy95YWhvby9saWJ5YWhvbzIuYw0KPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQ0KLS0tIGNvcmUvcGx1Z2lucy95YWhvby9saWJ5YWhvbzIuYwko
cmV2aXNpb24gMzYyKQ0KKysrIGNvcmUvcGx1Z2lucy95YWhvby9saWJ5YWhv
bzIuYwkod29ya2luZyBjb3B5KQ0KQEAgLTMzNjAsNyArMzM2MCw3IEBADQog
CQlERUJVR19NU0coKCJsZW4gPT0gJWQgKDw9IDApIiwgbGVuKSk7DQogDQog
CQlpZih5aWQtPnR5cGUgPT0gWUFIT09fQ09OTkVDVElPTl9QQUdFUikgew0K
LQkJCVlBSE9PX0NBTExCQUNLKGV4dF95YWhvb19sb2dpbl9yZXNwb25zZSko
eWlkLT55ZC0+Y2xpZW50X2lkLCBZQUhPT19MT0dJTl9TT0NLLCBOVUxMKTsN
CisJCQlZQUhPT19DQUxMQkFDSyhleHRfeWFob29fbG9naW5fcmVzcG9uc2Up
KHlpZC0+eWQtPmNsaWVudF9pZCwgWUFIT09fU09DS19FUlIsIE5VTEwpOw0K
IAkJfQ0KIA0KIAkJeWFob29fcHJvY2Vzc19jb25uZWN0aW9uW3lpZC0+dHlw
ZV0oeWlkLCAxKTsNCkluZGV4OiBjb3JlL3BsdWdpbnMveWFob28veWFob28y
X3R5cGVzLmgNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBjb3JlL3Bs
dWdpbnMveWFob28veWFob28yX3R5cGVzLmgJKHJldmlzaW9uIDM2MikNCisr
KyBjb3JlL3BsdWdpbnMveWFob28veWFob28yX3R5cGVzLmgJKHdvcmtpbmcg
Y29weSkNCkBAIC01Myw3ICs1Myw4IEBADQogCVlBSE9PX0xPR0lOX1BBU1NX
RCA9IDEzLA0KIAlZQUhPT19MT0dJTl9MT0NLID0gMTQsDQogCVlBSE9PX0xP
R0lOX0RVUEwgPSA5OSwNCi0JWUFIT09fTE9HSU5fU09DSyA9IC0xDQorCVlB
SE9PX0xPR0lOX1NPQ0sgPSAtMSwNCisJWUFIT09fU09DS19FUlIgPSAtMg0K
IH07DQogDQogZW51bSB5YWhvb19lcnJvciB7DQo=

---1463811291-1030253283-1084855611=:1020
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Everybuddy-Dev mailing list
[email protected]
http://lists.spine.cx/listinfo/everybuddy-dev

---1463811291-1030253283-1084855611=:1020--