Re: [DEV] Dialog changes

On Mon, 23 Feb 2004, Meredydd wrote:

> On Monday 23 February 2004 20:07, A. Craig West wrote:
> > --- core/src/gui_comms.c	(revision 295)
> > +++ core/src/gui_comms.c	(working copy)
> > @@ -84,6 +84,7 @@
> >  {
> >    char * title;
> >    char * message;
> > +  char * default_result;
> ...
> > +  char * is_html;
> 
> Cleanliness point - neither is_html nor default_result belong as strings 
> - both should be int flags (either true or false). Apart from that, 
> this is great stuff. Change it to int flags and commit!

I originally made them int flags, but then I noticed that all the
arguments to this point were the actual strings being sent to the gui. I was
going for consistency :-)

-- 
Craig West         Ph: (416) 666-1645	|  It's not a bug,
[email protected]              	|  It's a feature...