Adddressing the Smilies vs. Smileys madness
Nick Kocharhook <[email protected]> Mon, 17 Nov 2003 04:27:36 -0800
| Newsgroups | gmane.network.fire.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi all! I took a look at some of the work that's been going on recently and noticed that the new Smileys pref didn't behave quite right; checking the "Use graphical smileys" button didn't disable/enable the radio buttons. I investigated and discovered that the checkbox wasn't hooked up. A very quick fix, but one that laid bare one of the last remaining inconsistancies in naming: smilies vs. smileys. Well, now that we've got aSmileys pref pane, I think it's clear what we should be using. So I went through and changed everything to use the standard Smileys spelling: [Nick-Kocharhooks-Computer:~/Development/fire] nick% cvs -nq up [email protected]'s password: M Defines.h M MainController.m M MessageItem.m M NSAttributedStringAdditions.h M NSAttributedStringAdditions.m M StoredIMController.m M AIM-oscar/AIM-oscarCFunctions.m M Preference Panes/Smileys/SmileysPane.h M Preference Panes/Smileys/SmileysPane.m M Preference Panes/Smileys/English.lproj/SmileysPane.nib/classes.nib M Preference Panes/Smileys/English.lproj/SmileysPane.nib/info.nib M Preference Panes/Smileys/English.lproj/SmileysPane.nib/objects.nib [Nick-Kocharhooks-Computer:~/Development/fire] nick% Of course, I left the actual name of the preference alone; but the #define got changed. I didn't want to check this in before getting the OK, as it's a pretty major change. I've compiled the code and everything seems to work w.r.t. smileys. Good work all! Talk to you soon. -- Nick Kocharhook -- <avpx-y3TqMmYvUjih/[email protected]> -- Rot-13 ------------------------------------------------------- This SF. Net email is sponsored by: GoToMyPC GoToMyPC is the fast, easy and secure way to access your computer from any Web browser or wireless device. Click here to Try it Free! https://www.gotomypc.com/tr/OSDN/AW/Q4_2003/t/g22lp?Target=mm/g22lp.tmpl