Re: releasing next

--nextPart2096273.vhGWU34lcA
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

On Friday, March 16, 2018 08:32:42 PM Arne Babenhauserheide wrote:
> Hi,
>=20
> From my side, it=E2=80=99s finally time to create a release from next=
. The steps
> I see are:
>=20
> - ship jna.jar as new dependency and add it to wrapper.conf
> - ship freenet.jar as built from gradle
>=20
> Did I miss something?

Travis CI unit tests were disabled by Florent on Java 7 (which Ubuntu s=
till=20
ships and maintains) which hides the failure of a crypto test.

I filed a PR to re-enable them to force us to fix the test failure.
But he closed it due to what could from an optimistic point of view be=20=

paraphrased as a repeated misunderstanding:
https://github.com/freenet/fred/pull/623

It could be interpreted as him believing the PR would intend to fix the=
 unit=20
test failure, which it doesn't so he closed it.
It doesn't intend to fix the test failure as I'm not qualified to revie=
w=20
crypto code.

It intends to fix the fact that the failures were hidden by disabling *=
all*
tests for OpenJDK 7, and it succeeds at that.
Which is a valid concern IMHO, automated unit tests exist for a reason =
and=20
that reason is that they should fail if there is breakage until the bre=
akage=20
is fixed.

FWIW as Florent seems to not enjoy such basic code quality measures ver=
y much=20
I would focus on delivering a fix to the crypto test failure along with=
 the PR=20
to re-enable the tests so it's easier for him to swallow that pill alon=
g with=20
something sweet.
--nextPart2096273.vhGWU34lcA
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAABCAAGBQJarJh+AAoJEMtmZ+8tjWt5bvEP/3zRyh/p0YZ8Uz3JQSZqhSZq
e7Rj110SJmPuBGHlmewnkEwesCmGYChYXAWSnVdmdMenfPDnjuGHdzE8n8N2KyFo
dRm5/PFuUHyFMDVKAPFPmiFrAD3vdL9BkjwwFcX3Czon3WW3Tk5wNXxyoVUJLD5X
8mbroAKK0PJnOV1hyS7vY6GVqHeUzapWGcg9GQWKTW35iGirNViNxVUS7gsItNCM
M1kGpLS8QDrB7/iaUO4xvsIduwaCax9F7cW1LorP+0h7rKx2QEUL2uVaBnR9CBSO
1rsyRtFFd6xVY/uQDumLvJ57xDziUe+2NSJqVmgucrLCyIMpYD5lLQn8bisLDKNK
4Q1ybyfnoYYjcuTZ+Vw/S1+0bHTgtd4jiZriv73ns1JUM2rvoUIwd7axN7Knp1Vc
ZU+sYw+a5t33gE9WFESL6DSUvHgqhYfYEBIOanU31oOll7kay+slecURAtAUzHIV
8WOc0UuX5OfSk+IyFsZSGNTyUohMaXPTsAZ7dG2xgyF4bhXRO/vOGUjaMDMEQMuQ
4j0Tt7WBTthpLD46wnvkn5iA4ga7u34+XD4aWcRuSM123Llvwc1iojEVNKNVZdpi
LMJyMjpberVAaUmte8S1UQgCM6nd1xH08YrOUwnXVMDr83DBsCxa0T5o0nDouXuJ
0cJvBhCq694KUSq47NuA
=C2R/
-----END PGP SIGNATURE-----

--nextPart2096273.vhGWU34lcA--