Re: releasing next

--=-+34ykmP76e7L40Qp1MQd
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, 2018-03-17 at 05:24 +0100, [email protected] wrote:
> On Friday, March 16, 2018 08:32:42 PM Arne Babenhauserheide wrote:
> > Hi,
> >=20
> > From my side, it=E2=80=99s finally time to create a release from next. =
The
> > steps
> > I see are:
> >=20
> > - ship jna.jar as new dependency and add it to wrapper.conf
> > - ship freenet.jar as built from gradle
> >=20
> > Did I miss something?
>=20
> Travis CI unit tests were disabled by Florent on Java 7 (which Ubuntu
> still=20
> ships and maintains) which hides the failure of a crypto test.
>=20
> I filed a PR to re-enable them to force us to fix the test failure.
> But he closed it due to what could from an optimistic point of view
> be=20
> paraphrased as a repeated misunderstanding:
> https://github.com/freenet/fred/pull/623
>=20
> It could be interpreted as him believing the PR would intend to fix
> the unit=20
> test failure, which it doesn't so he closed it.
> It doesn't intend to fix the test failure as I'm not qualified to
> review=20
> crypto code.
>=20
> It intends to fix the fact that the failures were hidden by disabling
> *all*
> tests for OpenJDK 7, and it succeeds at that.
> Which is a valid concern IMHO, automated unit tests exist for a reason
> and=20
> that reason is that they should fail if there is breakage until the
> breakage=20
> is fixed.
>=20
> FWIW as Florent seems to not enjoy such basic code quality measures
> very much=20
> I would focus on delivering a fix to the crypto test failure along
> with the PR=20
> to re-enable the tests so it's easier for him to swallow that pill
> along with=20
> something sweet.

1) How is that different from what's on master? last time I've checked,
none of the CI builds have passed for the last few releases... and that
hasn't prevented releases from happening.
https://travis-ci.org/freenet/fred/branches

2) Who said that we support ubuntu? The build target has always been
debian-stable. We have been talking about getting rid of JDK7 support
for a while and I don't have a problem with ignoring ubuntu's release
schedule.

3) You still haven't demonstrated anything. Your pull request is garbage
and was rejected as such.

- The title is misleading:
"Travis CI: Fix for OpenJDK 7 by not using wrapper; shows our own tests
fail on OpenJDK 7"
  How the hell am I supposed not to assume it fixes "something"? If it
doesn't, why has it been submitted?

- It doesn't do what you've explained above: it first changes the build
script not to use the gradle wrapper and THEN re-enables openjdk7.
  It fails at both proving that there is a problem and fixing it... but
succeeds at removing determinism and breaking reproducible builds.
Congratz!

4) I don't call you by your first name, I would appreciate if you didn't
either... I don't know you.

NextGen$
--=-+34ykmP76e7L40Qp1MQd
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEE27dzODvDSclSA+2R6sXr8HqpwqMFAlqs0IUACgkQ6sXr8Hqp
wqMjGQgAjMCJGjVx62yX+QgHjDkEQ7whlK4A5ggeCnphV7ehc8hQ2z6H/VUWlh5z
rPpUsFNLNhcx5IYjv2JInRPeOUmkmn4ma7aboNwdUQxovThVrV/yyPx49sfgNa1c
OiRbASZieP6487ntY0VX7qsr3KhHtF5Rx/JTLUsR6zGM7WVEhbZAjzUMwPDzgwMk
S33Lf6A3jI61y21Sk6f1hxu0RMxhtME5HiXkGLkJUOIoT5itNZIPQ0P11XIfuZhE
pJLMjdvhXXW+jtJb5KmPSyKq2GmvmK6gbzL6EX45Ff2YT3s3qOJo75nTzEnqudsF
bNo0u/3ojjhyhp460JPulfmoujzmsA==
=FfT8
-----END PGP SIGNATURE-----

--=-+34ykmP76e7L40Qp1MQd--