Re: [PATCH] gnunetchat: skip_msg_handing: a label can only be part of a statement and a declaration is not a statement

On 2024-03-23 18:23, Andreas Stieger wrote:
> seen in gcc7 (vs. 13):
>
> [   22s] FAILED: libgnunetchat.so.p/src_gnunet_chat_handle.c.o
> [   22s] cc -Ilibgnunetchat.so.p -I. -I.. -Isrc -I../src
> -I../include/gnunet -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64
> -Wall -Winvalid-pch -fmessage-length=0 -grecord-gcc-switches -O2 -Wall
> -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables
> -fasynchronous-unwind-tables -fstack-clash-protection -g -fPIC -MD -MQ
> libgnunetchat.so.p/src_gnunet_chat_handle.c.o -MF
> libgnunetchat.so.p/src_gnunet_chat_handle.c.o.d -o
> libgnunetchat.so.p/src_gnunet_chat_handle.c.o -c
> ../src/gnunet_chat_handle.c
> [   22s] In file included from ../src/gnunet_chat_handle.c:27:0:
> [   22s] ../src/gnunet_chat_handle_intern.c: In function
> ‘on_handle_message_callback’:
> [   22s] ../src/gnunet_chat_handle_intern.c:921:3: error: a label can
> only be part of a statement and a declaration is not a statement
> [   22s]    const struct GNUNET_MESSENGER_Contact *sender =
> GNUNET_MESSENGER_get_sender(
> [   22s]    ^~~~~
>
> Fix:
>
> Index: libgnunetchat-0.3.0/src/gnunet_chat_handle_intern.c
> ===================================================================
> --- libgnunetchat-0.3.0.orig/src/gnunet_chat_handle_intern.c
> +++ libgnunetchat-0.3.0/src/gnunet_chat_handle_intern.c
> @@ -918,6 +918,7 @@ on_handle_message_callback(void *cls)
>    }
>
>  skip_msg_handing:
> +  ;
>    const struct GNUNET_MESSENGER_Contact *sender =
> GNUNET_MESSENGER_get_sender(
>      context->room, &(message->hash));
>
>
>

Fixes: ec977be