Re: [PATCH] gnunetchat: skip_msg_handing: a label can only be part of a statement and a declaration is not a statement

Jacki <[email protected]> Sat, 23 Mar 2024 23:35:21 +0100
Newsgroups gmane.network.gnunet.devel
Message-ID <6811d00a1f99636348d7b764445a827ba88cff81.camel@thejackimonster.de>
Thank you. The release of version 0.3.1 should fix that problem.

On Sat, 2024-03-23 at 18:26 +0100, Andreas Stieger wrote:
> 
> On 2024-03-23 18:23, Andreas Stieger wrote:
> > seen in gcc7 (vs. 13):
> > 
> > [   22s] FAILED: libgnunetchat.so.p/src_gnunet_chat_handle.c.o
> > [   22s] cc -Ilibgnunetchat.so.p -I. -I.. -Isrc -I../src
> > -I../include/gnunet -fdiagnostics-color=always -
> > D_FILE_OFFSET_BITS=64
> > -Wall -Winvalid-pch -fmessage-length=0 -grecord-gcc-switches -O2 -
> > Wall
> > -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables
> > -fasynchronous-unwind-tables -fstack-clash-protection -g -fPIC -MD
> > -MQ
> > libgnunetchat.so.p/src_gnunet_chat_handle.c.o -MF
> > libgnunetchat.so.p/src_gnunet_chat_handle.c.o.d -o
> > libgnunetchat.so.p/src_gnunet_chat_handle.c.o -c
> > ../src/gnunet_chat_handle.c
> > [   22s] In file included from ../src/gnunet_chat_handle.c:27:0:
> > [   22s] ../src/gnunet_chat_handle_intern.c: In function
> > ‘on_handle_message_callback’:
> > [   22s] ../src/gnunet_chat_handle_intern.c:921:3: error: a label
> > can
> > only be part of a statement and a declaration is not a statement
> > [   22s]    const struct GNUNET_MESSENGER_Contact *sender =
> > GNUNET_MESSENGER_get_sender(
> > [   22s]    ^~~~~
> > 
> > Fix:
> > 
> > Index: libgnunetchat-0.3.0/src/gnunet_chat_handle_intern.c
> > ===================================================================
> > --- libgnunetchat-0.3.0.orig/src/gnunet_chat_handle_intern.c
> > +++ libgnunetchat-0.3.0/src/gnunet_chat_handle_intern.c
> > @@ -918,6 +918,7 @@ on_handle_message_callback(void *cls)
> >    }
> > 
> >  skip_msg_handing:
> > +  ;
> >    const struct GNUNET_MESSENGER_Contact *sender =
> > GNUNET_MESSENGER_get_sender(
> >      context->room, &(message->hash));
> > 
> > 
> > 
> 
> Fixes: ec977be
> 
>
signature.asc (application/pgp-signature, 870 B)
-----BEGIN PGP SIGNATURE-----

iQJNBAABCAA3FiEEP1qkEG8usH2zEXZctAQYR5Y1TF4FAmX/WSkZHGphY2tpQHRo
ZWphY2tpbW9uc3Rlci5kZQAKCRC0BBhHljVMXq/LEACDbBcVLvg5LtsisvbxS3mx
0RbVdWVxFaD3uBnjGgSqfDBQ7K3T1DO95N7kLrzP3AtoY9NR6g3sc64a/0WsBkAW
IhyuZG1jUlO/r1i6nZor0olfG2BM0bwNWyzymRIYj4D8SlzRMr3dSj2F6emKn74H
oEz0W0oG5qQsTub8r7YDi0oAdiue5rx9NnBvtVlBA6iC5Dv0ocwduneGJE5fcR0n
O1Vq9O4HLJ7eJMCMuxSKVGW0Z9cAEVB2e5SNKIIhiHR/UN41dXT2XUzRiIUa1ntI
TXb5WyQX/WtGywgpxD0oCJYJIheBeHxDg6i0RT47ADXwRbsVZFua5dOgD8CsEUyj
ojNLk/90JROzsWe6BYN5HFKVgOfGm6fiqQOhZkI/SmJtKRuRPkaDO5aAE/WtcfBe
8SU03hRpNN6mJpfE3hBJhGzkhcLMixspqaL4qEgGLsMgZJ88An+rUK/yc2ORl6Kf
+OUuLktSdMBxW1Bnehrx9dyVNrWRHfn77Nsi7miYdk3kAfbnLH/GuuiMmyqxYLRc
eqlhweRvqyhwRuC4+D/hFhqs/ghDIlPysT/zQaXR63KMkAbGBBaWsv2yDAyEDK31
JO90PIMWgc6Fp946Zt50YAgyT1Fs96UPoWGMCW0/gHDjvnQ2uCEiW9dgJsEtht7J
TgiHTJo/7+ie8biZS2gjMQ==
=Aolr
-----END PGP SIGNATURE-----