[ ayttm-Patches-2830610 ] aspell patch for ayttm-0.5.0-111

Patches item #2830610, was opened at 2009-08-01 01:05
Message generated for change (Settings changed) made by pstef
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=550746&aid=2830610&group_id=77614

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: pigiron (pigiron)
>Assigned to: Nobody/Anonymous (nobody)
Summary: aspell patch for ayttm-0.5.0-111

Initial Comment:
Thanks for updating this application. It appears that spell checking doesn't work anymore because over the years pspell has gone dead and the configure script was *way* out of date. Since my spelling is so poor, I modified ayttm-0.5.0-111 so that it would work with the aspell libraries and I thought I'd pass on my changes.

Since these changes touch the "configure.ac" file, the "autotools" (autoconfig, automake, etc) need to be run in order to pick up the changes. I included a "autogen.sh" script in the patch to make that happen easily; just change the file permissions to make it executable. After running it, then just do a normal "configure", "make", "make install", etc.

Since it's only been lightly tested on an Arch Linux box, I'd be surprised if there wasn't some bugs in there, but it seems to work for me.

Again, thanks again for updating and maintaining ayttm. Do what you will with these changes as I make no claim to them.


----------------------------------------------------------------------

Comment By: Siddhesh Poyarekar (siddheshp)
Date: 2009-08-01 07:16

Message:
Thanks, the patch looks quite good. I'm not going to include the autogen.sh
since we already have a "gen" script to do that. If you want it to run
automatically, you can ./configure with --enable-maintainer-mode.

----------------------------------------------------------------------

Comment By: Philip S Tellis (bluesmoon)
Date: 2009-08-01 02:21

Message:
aspell's probably better anyway and more future proof.

----------------------------------------------------------------------

Comment By: pigiron (pigiron)
Date: 2009-08-01 02:17

Message:
Sorry... previous comment was mine... wasn't logged in.

Maybe spell checking is working for some, but it wasn't being compiled in
on my box because HAVE_LIBPSPELL wasn't defined due to the
"AC_CHECK_LIB([pspell], [pspell_manager_check], [have_pspell=yes],
[have_pspell=no])" and the following AC_CHECK_LIB line in "configure.ac". 
At least I think that's the reason ;)

I'm certainly no expert in this stuff, but the current autoconfig manual
says that those two lines won't update config.h nor add the library during
linking. I was guessing that was the problem because even though my aspell
package included some pspell stuff (header, libs, etc) the magic
HAVE_LIBPSPELL just wouldn't appear.

So, I thought that since I'm going have to dig into that stuff anyway, why
not go on and change the whole thing to use aspell :)  Especially since
pspell seems to have withered on the vine back in 2001. But I've got no
problem if you want to ignore/delete/change this patch... it's your's to do
with as you please.


----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2009-08-01 01:37

Message:
"strange, I thought I'd already made it work with aspell about 5 or 6 years
ago, and there's already a gen script to run the autotools commands. We
added that right at the start."

Yea, that comment really wasn't for you folks... it was targeted for the
"general public" in case they wanted the patch.

----------------------------------------------------------------------

Comment By: Philip S Tellis (bluesmoon)
Date: 2009-08-01 01:22

Message:
The patch looks fine to me.  Siddhesh will have to look it over and decide
what to do.

----------------------------------------------------------------------

Comment By: Philip S Tellis (bluesmoon)
Date: 2009-08-01 01:19

Message:
ok, found the file

----------------------------------------------------------------------

Comment By: Philip S Tellis (bluesmoon)
Date: 2009-08-01 01:18

Message:
I don't see your patch attached anywhere.  It could just be that I find
this sourceforge interface quite confusing though.

----------------------------------------------------------------------

Comment By: Philip S Tellis (bluesmoon)
Date: 2009-08-01 01:15

Message:
strange, I thought I'd already made it work with aspell about 5 or 6 years
ago, and there's already a gen script to run the autotools commands.  We
added that right at the start.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=550746&aid=2830610&group_id=77614

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july