Re: Some pull requests on Github
Andreas Ericsson <[email protected]>
| Newsgroups | gmane.network.nagios.plugins.devel |
|---|---|
| Message-ID | <[email protected]> |
On 03/20/2013 10:59 PM, Holger Weiß wrote: > * Richard Leitner <me-M/[email protected]> [2013-03-20 18:25]: >> I've currently forked your git repository on Github (Nickname: g0hl1n). >> There I started to fix some Bugs from the SourceForge.net Bugtracker. >> >> For two of them I created the following Pull-Requests on Github: >> https://github.com/nagios-plugins/nagios-plugins/pull/42 >> https://github.com/nagios-plugins/nagios-plugins/pull/43 >> >> Due to the fact I got no response until now I'd like to ask if it was >> the correct way to do these changes? > > I've seen your pull requests, and they look just fine to me. We're all > a bit busy right now (the main project server has to be moved to a new > home and stuff like that), but I'll probably be able to look into the > open pull requests (and then preparing a new release) relatively soon. > A new release probably won't be necessary. One patch is a spelling fix only (which is trivially correct). Adding --timeout to check_nagios is obviously good, but since it runs locally I doubt it'll ever have time to trigger. ACK on both patches from me though, for what it's worth. They're both correct and follow the plugin coding standards as far as I could see. -- Andreas Ericsson [email protected] OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 Considering the successes of the wars on alcohol, poverty, drugs and terror, I think we should give some serious thought to declaring war on peace. ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________________ Nagios Plugin Development Mailing List Nagiosplug-devel-5NWGOfrQmneRv+LV9MX5upmplPMkL2fr@public.gmane.orget Unsubscribe at https://lists.sourceforge.net/lists/listinfo/nagiosplug-devel ::: Please include plugins version (-v) and OS when reporting any issue. ::: Messages without supporting info will risk being sent to /dev/null