Re: Some pull requests on Github

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

I don't wanted to trigger a new release.
I just wanted to know if my patches follow your guidlines, so I can continue fixing some bugs for you ;-)

So thanks for your acknowledgement Andreas.

And I'll add some more bug-fixing PullRequests for you.

regards,
Richard


- -------- Original-Nachricht --------
Von: Andreas Ericsson <[email protected]>
Gesendet: Thu Mar 21 11:00:00 MEZ 2013
An: Nagios Plugin Development Mailing List <[email protected]>
Betreff: Re: [Nagiosplug-devel] Some pull requests on Github

On 03/20/2013 10:59 PM, Holger Weiß wrote:
> * Richard Leitner <[email protected]> [2013-03-20 18:25]:
>> I've currently forked your git repository on Github (Nickname: g0hl1n).
>> There I started to fix some Bugs from the SourceForge.net Bugtracker.
>>
>> For two of them I created the following Pull-Requests on Github:
>> https://github.com/nagios-plugins/nagios-plugins/pull/42
>> https://github.com/nagios-plugins/nagios-plugins/pull/43
>>
>> Due to the fact I got no response until now I'd like to ask if it was
>> the correct way to do these changes?
>
> I've seen your pull requests, and they look just fine to me.  We're all
> a bit busy right now (the main project server has to be moved to a new
> home and stuff like that), but I'll probably be able to look into the
> open pull requests (and then preparing a new release) relatively soon.
>

A new release probably won't be necessary. One patch is a spelling fix
only (which is trivially correct). Adding --timeout to check_nagios is
obviously good, but since it runs locally I doubt it'll ever have time
to trigger.

ACK on both patches from me though, for what it's worth. They're both
correct and follow the plugin coding standards as far as I could see.

- --
Andreas Ericsson                   [email protected]
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.

- ------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________________
Nagios Plugin Development Mailing List [email protected]
Unsubscribe at https://lists.sourceforge.net/lists/listinfo/nagiosplug-devel
::: Please include plugins version (-v) and OS when reporting any issue.
::: Messages without supporting info will risk being sent to /dev/null


- ---
Richard Leitner

www.g0hl1n.net
-----BEGIN PGP SIGNATURE-----
Version: APG v1.0.8

iQFNBAEBCAA3BQJRSuP2MBxSaWNoYXJkIExlaXRuZXIgKEFQRyA0IEFuZHJvaWQp
IDxtZUBnMGhsMW4ubmV0PgAKCRBsKKZVLXbz7bFWCACdOUsgx3k9kMFwUHVewVv3
AAPyJT3P6XHKKZL67JM/2mWHd4oPIyqMNZ8PI4v4VNIL0Bvtw0MTxDRaBYs2jhd6
hNKn+XPYCx9I5Jv/KPsH60ofejmHON+TbGIy2qbUDecfCRiVLhZkEH4E+x8hSosm
R7994vhL7wwNKr4v1cRe4jw4kNAQjh1ytB3uqf9e7kKmwb3xFCOgeVPvkSh0vWJN
sX7zz3Vga8/2SvW+eeCQdTmI7xxiQE6iTYPor5CFyhOAAAEsJ3RB130gNsDEBhbo
cUkpLUVhKgMM2M2SCdC0SSOJNXEG60cPTlbSamkf1b6PpFBbgqpaL6bgK4zVC0By
=B6tV
-----END PGP SIGNATURE-----


------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________________
Nagios Plugin Development Mailing List [email protected]
Unsubscribe at https://lists.sourceforge.net/lists/listinfo/nagiosplug-devel
::: Please include plugins version (-v) and OS when reporting any issue. 
::: Messages without supporting info will risk being sent to /dev/null