probable error in "preconfigured" primary

Lindy Foster <[email protected]> Tue, 08 Jun 2004 11:29:42 -0700
Newsgroups gmane.network.net-policy.user
Message-ID <[email protected]>
This looks like an error (probably a cut-and-paste error) in the 
preconfigured primary (in preconfig.pm). In the actions clause, there
are these lines:

       actions =>
            [[sub {
                if (!$_[0]->primary_was_run('ahTransform')) {
                  np_add_policy_contents('netpolicyconfig.ipspAhTransformTable',
                                         'AhTransName',
                                         qwparam('AhTransName'));
                }
                if (!$_[0]->primary_was_run('ahTransform')) {
                  np_add_policy_contents('netpolicyconfig.ipspAhTransformTable',
                                         'AhTransName',
                                         qwparam('AhTransName'));
                }

                if (!$_[0]->primary_was_run('pickipcomp')) {
                  np_add_policy_contents('netpolicyconfig.ipspEspTransformTable',
                                         'EspTransName',
                                         qwparam('EspTransName'));
                }
                return 'OK';
              }],

NOte that the first two if statements are identical, and the third one
says, if ipcomp, add espTrans. It looks to me like there should be one
for each of AH, ESP, and ipcomp. If no one can dispel this, I will go
ahead and make this change.

thanks,

lindy



-------------------------------------------------------
This SF.Net email is sponsored by: GNOME Foundation
Hackers Unite!  GUADEC: The world's #1 Open Source Desktop Event.
GNOME Users and Developers European Conference, 28-30th June in Norway
http://2004/guadec.org