Re: Suggested patch to support NetBSD 8

On 05/14/18 05:29, Niels Baggesen via Net-snmp-coders wrote:
> The patch that went into 5.7-patches is not sufficient for NetBSD 8 on
> 5.8
> 
> The following patch to 5.8.RC1 is required.
> 
> May I solicit some votes?
> 
> diff --git a/agent/mibgroup/mibII/at.h b/agent/mibgroup/mibII/at.h
> index 1676cb6..e89b966 100644
> --- a/agent/mibgroup/mibII/at.h
> +++ b/agent/mibgroup/mibII/at.h
> @@ -53,7 +53,7 @@ config_require(mibII/data_access/at_solaris)
>   #elif defined(linux)
>   config_require(mibII/data_access/at_linux)
>   config_require(mibII/data_access/at_unix)
> -#elif defined(HAVE_SYS_SYSCTL_H) && defined(RTF_LLINFO)
> +#elif defined(HAVE_SYS_SYSCTL_H) && (defined(RTF_LLINFO) || defined(RTF_LLDATA))
>   config_require(mibII/data_access/at_sysctl)
>   config_require(mibII/data_access/at_unix)
>   #elif defined(HAVE_NLIST_H)
> diff --git a/agent/mibgroup/mibII/data_access/at_sysctl.c b/agent/mibgroup/mibII/data_access/at_sysctl.c
> index d80228e..dfc207c 100644
> --- a/agent/mibgroup/mibII/data_access/at_sysctl.c
> +++ b/agent/mibgroup/mibII/data_access/at_sysctl.c
> @@ -54,6 +54,8 @@ ARP_Scan_Init(void)
>       mib[4] = NET_RT_FLAGS;
>   #if defined RTF_LLINFO
>       mib[5] = RTF_LLINFO;
> +#elif defined(RTF_LLDATA)
> +    mib[5] = RTF_LLDATA;
>   #else
>       mib[5] = 0;
>   #endif

Although I'm not familiar with the NetBSD MIB-II implementation, the 
above patch looks fine to me.

Bart.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot