Re: RFC: fix clientaddr for 5.8

On Mon, 14 May 2018 08:44:19 -0700 Bart wrote:
BVA> > https://sourceforge.net/p/net-snmp/code/ci/3defab66a7aee60ba582a8254412abd2e630c321/
BVA> > 
BVA> > It turns out that when you specify a clientaddr, the steps
BVA> > the function takes are:
BVA> > 
BVA> > - zero out addr_pair
BVA> > - store the remote address in addr_pair
BVA> > - lookup the clientaddr
BVA> > - zero out addr_pair
BVA> > - store the clientaddr in addr_pair
BVA> > 
BVA> > The second zeroing out (added in 
BVA> > cea974008da30de8d39a1f8ede7189265d93d598) results in the
BVA> > remote address being 0.0.0.0, which results in simply
BVA> > getting an error from sendto because you can not send to
BVA> > 0.0.0.0.
BVA> > 
BVA> > I'd like to merge this to master so that sessions using
BVA> > clientaddr work in the 5.8 release.  
BVA> 
BVA> If you want to avoid that commit fc14e89dd2a2 ("ifm_media
BVA> changed from u_int to uint64_t in OpenBSD 5.9") ends up on the
BVA> master branch you will have to do a git cherry-pick instead of
BVA> git merge. Otherwise I'm in favor of the above proposal.

+1 on both counts (commit it, but use cherry-pick).

Robert

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot