Re: [opennms-devel] [Fwd: [opennms-cvs] SF.net SVN: opennms: [8326] opennms/trunk/opennms-services/src/main/java/ org/opennms/netmgt/dhcpd/Dhcpd.java]

DJ Gregor <[email protected]>
Newsgroups gmane.network.opennms.bugs
Message-ID <[email protected]> 
Fixed in revision 8340.  Thanks for the report and sorry for the bug!

Note: due to quiet failures from hostname resolution failing with  
InetAddress.getLocalHost on misconfigured systems, DHCP could fail in  
the past with no clear explanation unless the user looked in the  
logs.  This is fixed with a startup check added a few weeks ago and  
the dhcp code used by capsd and the poller no longer uses that method.

On Feb 4, 2008, at 6:48 PM, DJ Gregor <[email protected]> wrote:

> DJ says: "oops".
>
> Apparently dhcpd clients don't talk to the server using
> 127.0.0.1. :-)   I'll work on it later tonight.
>
> On Feb 4, 2008, at 1:37 PM, ayresw <[email protected]> wrote:
>
>> This mod (rev 8326) breaks DHCP! I tested this by backing it out of  
>> my
>> system and verifying that the problem went away. Here are the errors
>> from poller.log:
>>
>> 2008-02-04 09:12:04,999 DEBUG [PollerScheduler-30 Pool-fiber26]
>> Poller:
>> Poller.ctor: opening socket connection with DHCP client daemon on  
>> port
>> 5818
>> 2008-02-04 09:12:05,001 ERROR [PollerScheduler-30 Pool-fiber26]
>> Poller:
>> IO Exception during socket connection establishment with DHCP client
>> daemon.
>> java.net.ConnectException: Connection refused
>>       at java.net.PlainSocketImpl.socketConnect(Native Method)
>>       at java.net.PlainSocketImpl.doConnect(PlainSocketImpl.java:333)
>>       at
>> java.net.PlainSocketImpl.connectToAddress(PlainSocketImpl.java:195)
>>       at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:182)
>>       at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:366)
>>       at java.net.Socket.connect(Socket.java:519)
>>       at java.net.Socket.connect(Socket.java:469)
>>       at java.net.Socket.<init>(Socket.java:366)
>>       at java.net.Socket.<init>(Socket.java:208)
>>       at org.opennms.netmgt.dhcpd.Poller.<init>(Poller.java:238)
>>       at org.opennms.netmgt.dhcpd.Poller.isServer(Poller.java:401)
>>       at org.opennms.netmgt.dhcpd.Dhcpd.isServer(Dhcpd.java:388)
>>       at
>> org.opennms.netmgt.poller.monitors.DhcpMonitor.poll(DhcpMonitor.java:
>> 130)
>>       at
>> org.
>> opennms.
>> netmgt.poller.pollables.LatencyStoringServiceMonitorAdaptor.poll
>> (LatencyStoringServiceMonitorAdaptor.java:90)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableServiceConfig.poll
>> (PollableServiceConfig.java:100)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableService.poll
>> (PollableService.java:143)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableElement.poll
>> (PollableElement.java:158)
>>       at org.opennms.netmgt.poller.pollables.PollableContainer
>> $4.run(PollableContainer.java:201)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableElement.withTreeLock
>> (PollableElement.java:143)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableElement.withTreeLock
>> (PollableElement.java:135)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableContainer.poll
>> (PollableContainer.java:208)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableInterface.poll
>> (PollableInterface.java:142)
>>       at org.opennms.netmgt.poller.pollables.PollableContainer
>> $4.run(PollableContainer.java:201)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableElement.withTreeLock
>> (PollableElement.java:143)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableElement.withTreeLock
>> (PollableElement.java:135)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableContainer.poll
>> (PollableContainer.java:208)
>>       at org.opennms.netmgt.poller.pollables.PollableNode
>> $3.run(PollableNode.java:230)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableElement.withTreeLock
>> (PollableElement.java:143)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableElement.withTreeLock
>> (PollableElement.java:135)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableNode.doPoll
>> (PollableNode.java:233)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableElement.doPoll
>> (PollableElement.java:114)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableService.doPoll
>> (PollableService.java:168)
>>       at org.opennms.netmgt.poller.pollables.PollableService
>> $PollRunner.run(PollableService.java:60)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableElement.withTreeLock
>> (PollableElement.java:143)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableService.doRun
>> (PollableService.java:289)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableService.run
>> (PollableService.java:275)
>>       at org.opennms.netmgt.scheduler.Schedule.run(Schedule.java:136)
>>       at org.opennms.netmgt.scheduler.Schedule
>> $ScheduleEntry.run(Schedule.java:82)
>>       at org.opennms.netmgt.scheduler.LegacyScheduler
>> $1.run(LegacyScheduler.java:292)
>>       at org.opennms.core.concurrent.RunnableConsumerThreadPool
>> $FiberThreadImpl.run(RunnableConsumerThreadPool.java:422)
>>       at java.lang.Thread.run(Thread.java:595)
>> 2008-02-04 09:12:05,002 DEBUG [PollerScheduler-30 Pool-fiber26]
>> DhcpMonitor: DhcpMonitor: An I/O exception occured during DHCP
>> discovery
>> java.net.ConnectException: Connection refused
>>       at
>> org.opennms.netmgt.poller.monitors.DhcpMonitor.poll(DhcpMonitor.java:
>> 135)
>>       at
>> org.
>> opennms.
>> netmgt.poller.pollables.LatencyStoringServiceMonitorAdaptor.poll
>> (LatencyStoringServiceMonitorAdaptor.java:90)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableServiceConfig.poll
>> (PollableServiceConfig.java:100)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableService.poll
>> (PollableService.java:143)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableElement.poll
>> (PollableElement.java:158)
>>       at org.opennms.netmgt.poller.pollables.PollableContainer
>> $4.run(PollableContainer.java:201)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableElement.withTreeLock
>> (PollableElement.java:143)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableElement.withTreeLock
>> (PollableElement.java:135)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableContainer.poll
>> (PollableContainer.java:208)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableInterface.poll
>> (PollableInterface.java:142)
>>       at org.opennms.netmgt.poller.pollables.PollableContainer
>> $4.run(PollableContainer.java:201)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableElement.withTreeLock
>> (PollableElement.java:143)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableElement.withTreeLock
>> (PollableElement.java:135)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableContainer.poll
>> (PollableContainer.java:208)
>>       at org.opennms.netmgt.poller.pollables.PollableNode
>> $3.run(PollableNode.java:230)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableElement.withTreeLock
>> (PollableElement.java:143)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableElement.withTreeLock
>> (PollableElement.java:135)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableNode.doPoll
>> (PollableNode.java:233)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableElement.doPoll
>> (PollableElement.java:114)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableService.doPoll
>> (PollableService.java:168)
>>       at org.opennms.netmgt.poller.pollables.PollableService
>> $PollRunner.run(PollableService.java:60)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableElement.withTreeLock
>> (PollableElement.java:143)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableService.doRun
>> (PollableService.java:289)
>>       at
>> org.opennms.netmgt.poller.pollables.PollableService.run
>> (PollableService.java:275)
>>       at org.opennms.netmgt.scheduler.Schedule.run(Schedule.java:136)
>>       at org.opennms.netmgt.scheduler.Schedule
>> $ScheduleEntry.run(Schedule.java:82)
>>       at org.opennms.netmgt.scheduler.LegacyScheduler
>> $1.run(LegacyScheduler.java:292)
>>       at org.opennms.core.concurrent.RunnableConsumerThreadPool
>> $FiberThreadImpl.run(RunnableConsumerThreadPool.java:422)
>>       at java.lang.Thread.run(Thread.java:595)
>>
>>
>> -------- Forwarded Message --------
>> From: [email protected]
>> To: [email protected]
>> Subject: [opennms-cvs] SF.net SVN: opennms: [8326]
>> opennms/trunk/opennms-services/src/main/java/
>> org/opennms/netmgt/dhcpd/Dhcpd.java
>> Date: Sat, 02 Feb 2008 11:49:29 -0800
>>
>> Revision: 8326
>>         http://opennms.svn.sourceforge.net/opennms/?rev=8326&view=rev
>> Author:   djgregor
>> Date:     2008-02-02 11:49:24 -0800 (Sat, 02 Feb 2008)
>>
>> Log Message:
>> -----------
>> Listen on 127.0.0.1.  We don't need to share our DHCP polling
>> service with the world.
>>
>> Modified Paths:
>> --------------
>>   opennms/trunk/opennms-services/src/main/java/org/opennms/netmgt/
>> dhcpd/Dhcpd.java
>>
>> Modified: opennms/trunk/opennms-services/src/main/java/org/opennms/
>> netmgt/dhcpd/Dhcpd.java
>> ===================================================================
>> --- opennms/trunk/opennms-services/src/main/java/org/opennms/netmgt/
>> dhcpd/Dhcpd.java    2008-02-02 19:46:27 UTC (rev 8325)
>> +++ opennms/trunk/opennms-services/src/main/java/org/opennms/netmgt/
>> dhcpd/Dhcpd.java    2008-02-02 19:49:24 UTC (rev 8326)
>> @@ -10,6 +10,8 @@
>> //
>> // Modifications:
>> //
>> +// 2008 Feb 02: Listen on 127.0.0.1.  We don't need to share our
>> DHCP polling
>> +//              service with the world.  Bug #2224. - [email protected]
>> // 2005 Jan 28: Added ability to listen on port 67 and/or 68
>> //              depending on config options
>> // 2003 Jan 31: Cleaned up some unused imports.
>> @@ -189,7 +191,7 @@
>>            if (log().isDebugEnabled()) {
>>                log().debug("start: listening on TCP port " +
>> dFactory.getPort() + " for incoming client requests.");
>>            }
>> -            m_server = new ServerSocket(dFactory.getPort());
>> +            m_server = new ServerSocket(dFactory.getPort(), 0,
>> InetAddress.getByName("127.0.0.1"));
>>        } catch (IOException ex) {
>>            throw new UndeclaredThrowableException(ex);
>>        }
>>
>>
>> This was sent by the SourceForge.net collaborative development
>> platform, the world's largest Open Source development site.
>>
>> ---
>> --- 
>> -------------------------------------------------------------------
>> This SF.net email is sponsored by: Microsoft
>> Defy all challenges. Microsoft(R) Visual Studio 2008.
>> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
>> _______________________________________________
>> Please read the OpenNMS Mailing List FAQ:
>> http://www.opennms.org/wiki/index.php?page=MailingListFaq
>> opennms-cvs mailing list
>>
>> To *unsubscribe* or change your subscription options, see the bottom
>> of this page:
>> https://lists.sourceforge.net/lists/listinfo/opennms-cvs
>>
>>
>> ---
>> --- 
>> -------------------------------------------------------------------
>> This SF.net email is sponsored by: Microsoft
>> Defy all challenges. Microsoft(R) Visual Studio 2008.
>> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
>> _______________________________________________
>> Please read the OpenNMS Mailing List FAQ:
>> http://www.opennms.org/index.php/Mailing_List_FAQ
>>
>> opennms-devel mailing list
>>
>> To *unsubscribe* or change your subscription options, see the bottom
>> of this page:
>> https://lists.sourceforge.net/lists/listinfo/opennms-devel
>
> --- 
> ----------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Please read the OpenNMS Mailing List FAQ:
> http://www.opennms.org/index.php/Mailing_List_FAQ
>
> opennms-devel mailing list
>
> To *unsubscribe* or change your subscription options, see the bottom  
> of this page:
> https://lists.sourceforge.net/lists/listinfo/opennms-devel

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/index.php/Mailing_List_FAQ

opennms-devel mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.