[OpenNMS/opennms] 13b5bc: NMS-20200: Handle Safari's callback-only requestPe...

Marshall Massengill via opennms-cvs <[email protected]> Mon, 10 Aug 2026 12:20:02 -0700

Newsgroups	gmane.network.opennms.cvs
Message-ID	<OpenNMS/opennms/push/refs/heads/mm/NMS-20200-smoke/[email protected]>

  Branch: refs/heads/mm/NMS-20200-smoke
  Home:   https://github.com/OpenNMS/opennms
  Commit: 13b5bc9032d82deb500482be362eb39196265fb0
      https://github.com/OpenNMS/opennms/commit/13b5bc9032d82deb500482be362eb39196265fb0
  Author: Marshall Massengill <[email protected]>
  Date:   2026-08-10 (Mon, 10 Aug 2026)

  Changed paths:
    M core/web-assets/src/main/assets/js/apps/notifications/index.js

  Log Message:
  -----------
  NMS-20200: Handle Safari's callback-only requestPermission()

Safari gained the promise form of Notification.requestPermission() late; older
versions are callback-only and return undefined, so calling .then() on the result
threw inside the click handler and the opt-in silently did nothing. Accept either
shape, guarding against browsers that honour both from invoking the callback
twice.



To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs