[OpenNMS/opennms] abaadf: NMS-20243: Register onms-tooltip in AdhocGraphBuil...
Scott Theleman via opennms-cvs <[email protected]>
| Newsgroups | gmane.network.opennms.cvs |
|---|---|
| Message-ID | <OpenNMS/opennms/push/refs/heads/jira/NMS-20243-move-icons-to-onms-ui/[email protected]> |
Branch: refs/heads/jira/NMS-20243-move-icons-to-onms-ui
Home: https://github.com/OpenNMS/opennms
Commit: abaadf4af45b4f4ebe76a126dc150d139b8adde5
https://github.com/OpenNMS/opennms/commit/abaadf4af45b4f4ebe76a126dc150d139b8adde5
Author: Scott Theleman <[email protected]>
Date: 2026-08-17 (Mon, 17 Aug 2026)
Changed paths:
M ui/tests/components/AdhocGraphs/AdhocGraphBuilder.test.ts
Log Message:
-----------
NMS-20243: Register onms-tooltip in AdhocGraphBuilder tests
AdhocGraphBuilder renders AdhocChartToolbar, which uses v-onms-tooltip in
eight places. The directive is registered app-level in
src/theme/primevue-setup.ts, which tests never run, and mountBuilder()
passed plugins and stubs but no directives -- so Vue emitted "Failed to
resolve directive: onms-tooltip" once per usage per render.
That was 92 of the 93 Vue warnings in the whole suite, all from this one
file, each dragging a multi-line component stack trace into the output.
Confirmed by isolation: excluding this file from the run left zero tooltip
warnings. Registering the directive per-mount matches what the other eight
test files that mount tooltip-using components already do.
Suite warnings drop 93 -> 1 (the remaining one is an unrelated
invalid-NaN-key warning from a GraphDataTable fixture). 152 files /
2913 tests still pass; eslint clean.
Pre-existing noise, unrelated to the icon move in 97ef4809dff -- committed
separately for that reason.
To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications
_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list
To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs