[OpenNMS/opennms] 19827e: NMS-20243: Update stale src/components/icons refer...

  Branch: refs/heads/jira/NMS-20243-move-icons-to-onms-ui
  Home:   https://github.com/OpenNMS/opennms
  Commit: 19827ef8c4d1f9984890cca16970e737c673db80
      https://github.com/OpenNMS/opennms/commit/19827ef8c4d1f9984890cca16970e737c673db80
  Author: Scott Theleman <[email protected]>
  Date:   2026-08-17 (Mon, 17 Aug 2026)

  Changed paths:
    M ui/MENU_TEMPLATES.md
    M ui/THIRD-PARTY-LICENSE.md
    M ui/copilot-instructions.md
    M ui/scripts/generate-icons.mjs

  Log Message:
  -----------
  NMS-20243: Update stale src/components/icons references after the icon move

Follow-up to 97ef4809dff, which moved the 262 icon SFCs to
packages/onms-ui/src/icons/ but left four files still pointing at the old
path. Found by PR review.

- scripts/generate-icons.mjs: outBase was resolve('src/components/icons'),
  which resolves against process.cwd() -- and the script header says to run
  it from ui/. Regeneration would have written a fresh orphan tree at the
  old location while the live icons went untouched. This is the only
  functional fix of the four.
- THIRD-PARTY-LICENSE.md: the Apache-2.0 section 4(b) attribution entry for
  the 262 FeatherDS-derived SFCs listed a path that no longer exists. The
  path has to be accurate for the attribution to mean anything.
- copilot-instructions.md: carried verbatim the same line already corrected
  in CLAUDE.md; now matches, including the subpath-import example.
- MENU_TEMPLATES.md: pointed authors at the old directory for the list of
  valid icon IDs. The "action/AccountCircle" ID format itself is unchanged,
  since the move preserved the category directories.

Also corrects two pre-existing errors in the same lines: generate-icons.mjs
and THIRD-PARTY-LICENSE.md both described OnmsIcon.vue as living under
src/components/icons/, but it has been at
packages/onms-ui/src/components/OnmsIcon.vue.

A repo-wide sweep for "components/icons" now returns only deliberate
historical references. Verified: generator outBase resolves to the live tree
(12 category dirs present), node --check, eslint, vue-tsc, and 2913 tests
all pass. Note that generate-icons.mjs itself cannot be run end-to-end --
it needs @featherds/icon, which is no longer a dependency.



To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs