[OpenNMS/opennms] 771122: Update DCBTable to use OnmsIconButton

  Branch: refs/heads/jira/NMS-20160-search-input-etc
  Home:   https://github.com/OpenNMS/opennms
  Commit: 7711227a83d69949da2fe0c5a76e3a099f370ed8
      https://github.com/OpenNMS/opennms/commit/7711227a83d69949da2fe0c5a76e3a099f370ed8
  Author: Scott Theleman <[email protected]>
  Date:   2026-08-18 (Tue, 18 Aug 2026)

  Changed paths:
    M ui/src/components/Device/DCBTable.vue

  Log Message:
  -----------
  Update DCBTable to use OnmsIconButton


  Commit: cf4415042c80d1b508ce1318c11a9f216567cfa0
      https://github.com/OpenNMS/opennms/commit/cf4415042c80d1b508ce1318c11a9f216567cfa0
  Author: Scott Theleman <[email protected]>
  Date:   2026-08-18 (Tue, 18 Aug 2026)

  Changed paths:
    M ui/src/components/Menu/Menubar.vue

  Log Message:
  -----------
  NMS-20162: Correct the Menubar date-tooltip comment

The comment above dateTimeLabel credited the v-if with getting PrimeVue to
capture the tooltip z-index. That stopped being the reason in e34f6052db2,
where the OnmsTooltip seam wrapper took it over centrally: the v-if now just
keeps the directive from mounting without a label to show.

Also records why `.bottom` is on the directive, since with the z-index fixed it
otherwise reads as a leftover workaround: it is a placement choice. PrimeVue's
default `right` puts the tooltip inside the header band, covering the
neighbouring menubar items.

Comments only, no behavior change.


  Commit: 4074db7f25c325faebb02cc66aa36f53fdad2257
      https://github.com/OpenNMS/opennms/commit/4074db7f25c325faebb02cc66aa36f53fdad2257
  Author: Scott Theleman <[email protected]>
  Date:   2026-08-18 (Tue, 18 Aug 2026)

  Changed paths:
    M ui/src/components/EventConfiguration/EventConfigUploadFilesTab.vue
    M ui/tests/components/EventConfiguration/EventConfigUploadFilesTab.test.ts

  Log Message:
  -----------
  NMS-20162: Use OnmsIconButton for the duplicate-file action on the upload tab

The per-file duplicate indicator opens the rename/overwrite dialog, but it was
a bare OnmsIcon with a @click — a clickable <svg> no keyboard user could reach.
It is now an OnmsIconButton with the tooltip prop, so it is a real button and
the long "file is a duplicate" text stays in the tooltip while `title` carries
a short accessible name.

The valid/invalid indicators stay OnmsIcon: they are status only, and making
them buttons would have them announce as "Invalid file, button", advertising an
action that does not exist.

Its class now lands on the <button> instead of the <svg>, so the CSS keeps only
the status colour (the glyph inherits it through `fill: currentColor`) and lets
the component size the icon. That leaves it slightly smaller than the plain
status icons beside it but keeps every row the same height — sizing it up to
match made the duplicate row 4px taller than the rest.

Adds tests for both: clicking the duplicate button opens the rename dialog (the
interactive path, previously uncovered and the one whose host element changed),
and the status indicators render as tooltipped icons rather than buttons.


Compare: https://github.com/OpenNMS/opennms/compare/e34f6052db2d...4074db7f25c3

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs