[OpenNMS/opennms] 795271: NMS-20160: Fix the search/autocomplete clear affor...

  Branch: refs/heads/jira/NMS-20160-search-input-etc
  Home:   https://github.com/OpenNMS/opennms
  Commit: 795271a10279c571492cf8280e89571b294b6586
      https://github.com/OpenNMS/opennms/commit/795271a10279c571492cf8280e89571b294b6586
  Author: Scott Theleman <[email protected]>
  Date:   2026-08-18 (Tue, 18 Aug 2026)

  Changed paths:
    M ui/packages/onms-ui/src/components/OnmsAutoComplete.vue
    M ui/packages/onms-ui/src/components/OnmsSearchInput.vue
    M ui/tests/onms-ui/OnmsAutoComplete.test.ts

  Log Message:
  -----------
  NMS-20160: Fix the search/autocomplete clear affordances

OnmsAutoComplete.clearInput() assigned the DOM value directly, which never
runs PrimeVue's own onInput handler — the only place that cancels the
`delay` timer AutoComplete arms on every keystroke. Clearing inside that
300ms window left the timer running, so the stale query still reached the
caller via `complete` and MapSearch re-ran the search it had just
cancelled. Dispatch the input event instead; that also closes the overlay.

OnmsSearchInput: size the clear glyph to 1.5rem so it matches the leading
search glyph (primevue-overrides.scss normalizes .p-inputicon app-wide,
and --p-icon-size is 1rem), and drop its native `title` — it duplicated
aria-label as a browser tooltip, the same doubling OnmsIconButton's
nativeTitle exists to avoid.


  Commit: 135b8d96d5032cf4a455b0822f60f07234cdb7d6
      https://github.com/OpenNMS/opennms/commit/135b8d96d5032cf4a455b0822f60f07234cdb7d6
  Author: Scott Theleman <[email protected]>
  Date:   2026-08-18 (Tue, 18 Aug 2026)

  Changed paths:
    M ui/src/components/Device/DCBTable.vue
    M ui/tests/onms-ui/OnmsIconButton.test.ts

  Log Message:
  -----------
  NMS-20162: Keep the DCB config-type indicator a plain icon

Making it an OnmsIconButton added a second control navigating to the same
place as the node link beside it, named from data.configName with nothing
to say it navigates, and OnmsIconButton never gets PrimeVue's
p-button-icon-only class (it fills the default slot, not the `icon` slot),
so it rendered with full button padding inside the Node Name cell.

The conversion was never needed for the tooltip: with the OnmsTooltip
z-index fix, v-onms-tooltip on a plain OnmsIcon works — the upload tab's
status icons rely on exactly that.

Also drop the stray empty plugin/config from the OnmsIconButton test mount.


  Commit: 9e4d30d746017a523142a770ce54375365b4608e
      https://github.com/OpenNMS/opennms/commit/9e4d30d746017a523142a770ce54375365b4608e
  Author: Scott Theleman <[email protected]>
  Date:   2026-08-18 (Tue, 18 Aug 2026)

  Changed paths:
    M ui/src/components/Map/MapSearch.vue
    M ui/tests/components/Map/MapSearch.test.ts

  Log Message:
  -----------
  NMS-20160: Make the map search clear control a real button

It was an OnmsIcon with role="button", tabindex and hand-rolled Enter/Space
handling, and it was shown even with an empty field. Use a <button> so
activation, focus and semantics come from the platform, and render it only
when there is something to clear — a selected chip, or text typed but not
yet turned into one.

The typed query is tracked from the input event bubbling to the seam
component's root, since AutoComplete's inner input is uncontrolled in
`multiple` mode. Taking a suggestion empties that input inside PrimeVue
without firing `input`, so a growing selection resets the tracked query;
removing a chip leaves it alone. The slot holding the button stays in the
layout so the panel does not resize on the first keystroke.


Compare: https://github.com/OpenNMS/opennms/compare/4074db7f25c3...9e4d30d74601

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs