[OpenNMS/opennms] 09217f: NMS-6400: Model the TCP settings as a nested element

  Branch: refs/heads/mm/NMS-6400-smoke
  Home:   https://github.com/OpenNMS/opennms
  Commit: 09217fba05ff03c7ae2a47cb28d216e2c7ec8e31
      https://github.com/OpenNMS/opennms/commit/09217fba05ff03c7ae2a47cb28d216e2c7ec8e31
  Author: Marshall Massengill <[email protected]>
  Date:   2026-08-20 (Thu, 20 Aug 2026)

  Changed paths:
    M docs/modules/operation/pages/deep-dive/events/sources/syslog.adoc
    M docs/modules/reference/pages/daemons/daemon-config-files/syslogd.adoc
    M features/events/syslog/blueprint-syslog-listener-camel-netty.xml
    M features/events/syslog/blueprint-syslog-listener-javanet.xml
    M features/events/syslog/src/main/java/org/opennms/netmgt/syslogd/SinkDispatchingSyslogReceiver.java
    M features/events/syslog/src/main/java/org/opennms/netmgt/syslogd/SyslogTcpListener.java
    M features/events/syslog/src/main/java/org/opennms/netmgt/syslogd/SyslogTcpSslContextFactory.java
    M features/events/syslog/src/test/java/org/opennms/netmgt/syslogd/SyslogTcpListenerDispatchIT.java
    M features/events/syslog/src/test/java/org/opennms/netmgt/syslogd/SyslogTcpSslContextFactoryTest.java
    M features/events/syslog/src/test/java/org/opennms/netmgt/syslogd/SyslogdMultiListenerIT.java
    M features/events/syslog/src/test/java/org/opennms/netmgt/syslogd/SyslogdReceiverNettyTcpIT.java
    M features/events/syslog/src/test/java/org/opennms/netmgt/syslogd/SyslogdReceiverNettyTcpTlsIT.java
    M opennms-base-assembly/src/main/filtered/etc/syslogd-configuration.xml
    M opennms-config-model/src/main/java/org/opennms/netmgt/config/syslogd/Configuration.java
    M opennms-config-model/src/main/java/org/opennms/netmgt/config/syslogd/SyslogTcpConfig.java
    A opennms-config-model/src/main/java/org/opennms/netmgt/config/syslogd/SyslogTcpTlsConfig.java
    M opennms-config-model/src/main/resources/xsds/syslog.xsd
    M opennms-config-model/src/test/java/org/opennms/netmgt/config/syslogd/SyslogTcpConfigTest.java
    M opennms-config-model/src/test/java/org/opennms/netmgt/config/syslogd/SyslogdConfigurationTest.java

  Log Message:
  -----------
  NMS-6400: Model the TCP settings as a nested element

Review feedback: eleven attributes on the configuration element become an optional
tcp element carrying a nested tls one.

The presence of the element is now what asks for a listener, so port is required
inside it and the "unset means off" convention is gone from the XML. Grouping the
TLS settings also means a further one is an attribute on tls rather than another
tcp-tls-* attribute on the parent, which is already wide.

The .cfg keys a Minion uses are unchanged. Its blueprint builds the nested bean and
injects it, which is the same object graph the XML unmarshals into.

The tcp element may only appear once, matching what the runtime supports. Raising
that later is a schema change plus the work to own more than one listener.

Two details worth keeping:

The listen-address of the parent is still the fallback for the tcp element, passed
to the listener rather than copied into the element, so it does not reappear when
the configuration is marshalled. Binding TCP to every address while UDP was
restricted to one interface is a poor surprise.

The tls enabled attribute is a primitive. A nullable Boolean setter alongside a
boolean getter makes the property read-only under bean introspection, which the
blueprint rejects, and absence means false either way.



To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs