[OpenNMS/opennms] 493019: NMS-20100: point the notification bell at the noti...

joseanesONMS via opennms-cvs <[email protected]>
Newsgroups gmane.network.opennms.cvs
Message-ID <OpenNMS/opennms/push/refs/heads/jira/NMS-20100/[email protected]> 
  Branch: refs/heads/jira/NMS-20100
  Home:   https://github.com/OpenNMS/opennms
  Commit: 49301982a19cde740582de425ab95ad5b9b1f6a5
      https://github.com/OpenNMS/opennms/commit/49301982a19cde740582de425ab95ad5b9b1f6a5
  Author: Jose Anes <[email protected]>
  Date:   2026-08-11 (Tue, 11 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationRestService.java
    M opennms-webapp-rest/src/main/webapp/WEB-INF/menu/menu-template.json
    M ui/src/components/AdminNotifications/NotificationQueriesCard.vue
    M ui/src/components/Menu/UserNotificationsMenuItem.vue
    M ui/src/containers/Notifications.vue
    M ui/src/services/noticesService.ts
    M ui/src/stores/noticesStore.ts
    M ui/src/types/notices.ts
    M ui/tests/stores/noticesStore.test.ts

  Log Message:
  -----------
  NMS-20100: point the notification bell at the notifications page

Deep-link the top-bar notification bell to the notices page with a query
preset so the outstanding/team views open directly, re-applying the preset
when it changes without remounting. Carries the supporting notices store and
service changes.


  Commit: a68b3297df3340acf4b13b8653c4f03be6dc3724
      https://github.com/OpenNMS/opennms/commit/a68b3297df3340acf4b13b8653c4f03be6dc3724
  Author: Jose Anes <[email protected]>
  Date:   2026-08-11 (Tue, 11 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationConfigRestService.java
    M opennms-webapp-rest/src/test/java/org/opennms/web/rest/v1/NotificationConfigRestServiceIT.java
    M ui/src/components/AdminNotifications/ConfigureNotificationsDialog.vue
    A ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue
    A ui/src/components/AdminNotifications/EventNotificationsTable.vue
    M ui/src/services/index.ts
    M ui/src/services/notificationConfigService.ts
    M ui/src/stores/notificationConfigStore.ts
    M ui/src/types/notificationConfig.ts
    M ui/tests/stores/notificationConfigStore.test.ts

  Log Message:
  -----------
  NMS-20100: Event Notifications tab

Add the Event Notifications tab: a table listing notifications with a
read-only status tag, icon actions and an overflow menu for enable/disable,
plus an editor dialog for the UEI, targets, rule and advanced parameters.
Fields use the FormField seam with inline info-icon help; long UEIs are
truncated so the table does not scroll horizontally.


  Commit: 2aa0f7b7e0ca29d14d598648f93f620494025175
      https://github.com/OpenNMS/opennms/commit/2aa0f7b7e0ca29d14d598648f93f620494025175
  Author: Jose Anes <[email protected]>
  Date:   2026-08-11 (Tue, 11 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationConfigRestService.java
    M ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue
    M ui/src/services/notificationConfigService.ts

  Log Message:
  -----------
  NMS-20118: only materialize the rule match preview on request; map infra errors correctly

Add a preview flag to the rule-validate endpoint so the save path pays only for
filterDao.validateRule; the full interface/service map is built solely for the
explicit match preview. Narrow the rule-validation catches to FilterParseException
so a malformed rule stays a user error while infrastructure failures propagate as
a 500 instead of a misleading 400.


  Commit: a88da025bc383931967d8d35a93e47e57bd5e34a
      https://github.com/OpenNMS/opennms/commit/a88da025bc383931967d8d35a93e47e57bd5e34a
  Author: Jose Anes <[email protected]>
  Date:   2026-08-11 (Tue, 11 Aug 2026)

  Changed paths:
    M ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue
    M ui/src/components/AdminNotifications/EventNotificationsTable.vue
    M ui/src/types/notificationConfig.ts

  Log Message:
  -----------
  NMS-20118: address review findings on the event notification editor

Preserve an existing notification's rule verbatim on open (guard the builder-to-rule sync during population), reject blank parameter values before save, and skip service names that aren't legal filter identifiers when building the rule. Also correct the writeable type to boolean, render the add button icon via OnmsIcon instead of a raw PrimeIcons class.


  Commit: 91d27aee95393e3f527c5d0f17701ed1d7dc22cf
      https://github.com/OpenNMS/opennms/commit/91d27aee95393e3f527c5d0f17701ed1d7dc22cf
  Author: Jose Anes <[email protected]>
  Date:   2026-08-11 (Tue, 11 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/test/java/org/opennms/web/rest/v1/NotificationConfigRestServiceIT.java

  Log Message:
  -----------
  NMS-20118: IT coverage for the service list and rule validation endpoints

Add integration tests for GET /services and POST /rule/validate (including the
preview flag that gates the match-map materialization and a blank-rule
rejection), and extend the non-admin authorization test to the services, rule
validation, notification create and delete endpoints.


  Commit: c6c112313fd7388d4252ae5a872e43a868cc7c07
      https://github.com/OpenNMS/opennms/commit/c6c112313fd7388d4252ae5a872e43a868cc7c07
  Author: Jose Anes <[email protected]>
  Date:   2026-08-18 (Tue, 18 Aug 2026)

  Changed paths:
    R opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationConfigRestService.java
    A opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/NotificationConfigRestService.java
    R opennms-webapp-rest/src/test/java/org/opennms/web/rest/v1/NotificationConfigRestServiceIT.java
    A opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/NotificationConfigRestServiceIT.java
    M ui/src/services/notificationConfigService.ts
    M ui/src/types/notificationConfig.ts

  Log Message:
  -----------
  NMS-20118: move the notification-config REST service to v2 as clean JSON

Relocate NotificationConfigRestService (and its IT) from rest.v1 to rest.v2 so
it is served under /api/v2/notification-config. Decouple it from the v1
OnmsRestService base: the read/write/update lock and the getException helpers
it used now live on the service itself. Drop the m_ prefixes and the JAXB
annotations from the inner DTOs so they are plain camelCase-JSON POJOs (the wire
names are unchanged). The UI service now calls the v2 axios instance.


  Commit: a593e5562b3ad4cdd33293705bcde21ad40f6bf5
      https://github.com/OpenNMS/opennms/commit/a593e5562b3ad4cdd33293705bcde21ad40f6bf5
  Author: Jose Anes <[email protected]>
  Date:   2026-08-19 (Wed, 19 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/NotificationConfigRestService.java

  Log Message:
  -----------
  NMS-20118: drop m_ prefixes and the local isBlank helper

Address review: remove the m_ prefix from the service fields (eventProxy and the
lock fields), drop the now-redundant @Qualifier (the field name matches the bean),
and use org.apache.commons.lang.StringUtils.isBlank instead of the hand-rolled
helper.


  Commit: a70befa0b7f51b1eb92a723ff58df7c82edae671
      https://github.com/OpenNMS/opennms/commit/a70befa0b7f51b1eb92a723ff58df7c82edae671
  Author: Jose Anes <[email protected]>
  Date:   2026-08-20 (Thu, 20 Aug 2026)

  Changed paths:
    R opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationConfigRestService.java
    A opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/NotificationConfigRestService.java
    R opennms-webapp-rest/src/test/java/org/opennms/web/rest/v1/NotificationConfigRestServiceIT.java
    A opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/NotificationConfigRestServiceIT.java
    M ui/src/components/AdminNotifications/ConfigureNotificationsDialog.vue
    A ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue
    A ui/src/components/AdminNotifications/EventNotificationsTable.vue
    M ui/src/services/index.ts
    M ui/src/services/notificationConfigService.ts
    M ui/src/stores/notificationConfigStore.ts
    M ui/src/types/notificationConfig.ts
    M ui/tests/stores/notificationConfigStore.test.ts

  Log Message:
  -----------
  Merge #8710 (NMS-20118 Event Notifications) into epic


  Commit: 78f863e812a76e705ef2da0fb79e07561d4f278e
      https://github.com/OpenNMS/opennms/commit/78f863e812a76e705ef2da0fb79e07561d4f278e
  Author: Jose Anes <[email protected]>
  Date:   2026-08-20 (Thu, 20 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationRestService.java
    M opennms-webapp-rest/src/main/webapp/WEB-INF/menu/menu-template.json
    M ui/src/components/AdminNotifications/NotificationQueriesCard.vue
    M ui/src/components/Menu/UserNotificationsMenuItem.vue
    M ui/src/containers/Notifications.vue
    M ui/src/services/noticesService.ts
    M ui/src/stores/noticesStore.ts
    M ui/src/types/notices.ts
    M ui/tests/stores/noticesStore.test.ts

  Log Message:
  -----------
  Merge #8719 (NMS-20124 notification bell) into epic


Compare: https://github.com/OpenNMS/opennms/compare/e973d44f40ad...78f863e812a7

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.