[OpenNMS/opennms] 06640b: NMS-20108: calendar resilience, schema-range guard...

joseanesONMS via opennms-cvs <[email protected]> Tue, 01 Sep 2026 09:05:49 -0700

Newsgroups	gmane.network.opennms.cvs
Message-ID	<OpenNMS/opennms/push/refs/heads/jira/NMS-20108-oncall-roles-pr/[email protected]>

  Branch: refs/heads/jira/NMS-20108-oncall-roles-pr
  Home:   https://github.com/OpenNMS/opennms
  Commit: 06640b4d5e2bb84b280f43ed2ee55021f180cc2e
      https://github.com/OpenNMS/opennms/commit/06640b4d5e2bb84b280f43ed2ee55021f180cc2e
  Author: Jose Anes <[email protected]>
  Date:   2026-09-01 (Tue, 01 Sep 2026)

  Changed paths:
    M opennms-config/src/main/java/org/opennms/netmgt/config/GroupManager.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/OnCallRolesRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/model/OnCallCalendarDto.java
    M opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/OnCallRolesRestServiceIT.java
    M ui/src/components/ManageOnCallRoles/RoleCalendarDialog.vue
    M ui/src/types/onCallRoleAdmin.ts

  Log Message:
  -----------
  NMS-20108: calendar resilience, schema-range guards, wider non-admin coverage !smoke

The calendar endpoint now loads the role once and resolves every day from
that snapshot (new GroupManager overload skipping the per-call update()),
and an entry the interval math cannot evaluate - e.g. a hand-edited
overnight window - marks the response with schedule-error instead of
turning a valid GET into a 400 with an internal message. The dialog shows
that as a warning banner.

Validation now rejects years outside groups.xsd's 1000-2999 before the
marshal can fail, blocks C0 control characters in role names, and the
overnight-shift rejection explains splitting into two entries. The date
pickers pin the same range. The non-admin IT covers PUT, rename, and
calendar; new ITs cover the overnight tolerance, the year guard, the
control-character guard, and the split hint. 22 ITs green locally.



To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs