[OpenNMS/opennms] e328f3: NMS-20026: Fix TicketNotificationStrategy wiring
OpenNMS Machine User via opennms-cvs <[email protected]> Thu, 30 Jul 2026 14:49:13 -0700
| Newsgroups | gmane.network.opennms.cvs |
|---|---|
| Message-ID | <OpenNMS/opennms/push/refs/heads/release-36.x/[email protected]> |
Branch: refs/heads/release-36.x
Home: https://github.com/OpenNMS/opennms
Commit: e328f31dee837e1637cfcc5f63f6174004829776
https://github.com/OpenNMS/opennms/commit/e328f31dee837e1637cfcc5f63f6174004829776
Author: Chandra Gorantla <[email protected]>
Date: 2026-07-15 (Wed, 15 Jul 2026)
Changed paths:
M features/notifications/ticket-strategy/src/main/java/org/opennms/netmgt/notifd/TicketNotificationStrategy.java
M features/notifications/ticket-strategy/src/test/java/org/opennms/netmgt/notifd/TicketNotificationStrategyTest.java
Log Message:
-----------
NMS-20026: Fix TicketNotificationStrategy wiring
Commit: 3fe2678de6f6ef8bfdfd9fd57a4b9ba746eb8230
https://github.com/OpenNMS/opennms/commit/3fe2678de6f6ef8bfdfd9fd57a4b9ba746eb8230
Author: Marshall Massengill <[email protected]>
Date: 2026-07-29 (Wed, 29 Jul 2026)
Changed paths:
M docs/modules/operation/nav.adoc
M docs/modules/operation/pages/deep-dive/notifications/bonus-strategies.adoc
A docs/modules/operation/pages/deep-dive/notifications/strategies/ticket.adoc
M features/notifications/ticket-strategy/src/main/java/org/opennms/netmgt/notifd/TicketNotificationStrategy.java
M features/notifications/ticket-strategy/src/test/java/org/opennms/netmgt/notifd/TicketNotificationStrategyTest.java
M opennms-base-assembly/src/main/filtered/etc/examples/destinationPaths.xml
M opennms-base-assembly/src/main/filtered/etc/examples/notificationCommands.xml
Log Message:
-----------
NMS-20101: Make TicketNotificationStrategy usable and document it
The strategy shipped with no reference in any notificationCommands.xml,
so it was unreachable without hand-written configuration, and its
delivery-time alarm lookup fails when a destination path fires before
alarmd has associated the event with an alarm.
Adds a createTicket example command and a Create-Ticket example
destination path with a non-zero initial-delay to work around the
alarmd race, plus a strategy page in the notifications docs covering
the prerequisites and caveats.
Replaces the hardcoded admin ticket user with an optional ticketUser
argument that can be set per notification; absent or blank values fall
back to admin, preserving the previous behavior.
Commit: 7577c600430af0aa4b84c5ff5cdd9eab9df26da4
https://github.com/OpenNMS/opennms/commit/7577c600430af0aa4b84c5ff5cdd9eab9df26da4
Author: Marshall Massengill <[email protected]>
Date: 2026-07-29 (Wed, 29 Jul 2026)
Changed paths:
M docs/modules/operation/pages/deep-dive/notifications/strategies/ticket.adoc
M features/notifications/ticket-strategy/src/main/java/org/opennms/netmgt/notifd/TicketNotificationStrategy.java
M opennms-base-assembly/src/main/filtered/etc/examples/destinationPaths.xml
Log Message:
-----------
NMS-20101: Address review feedback
Adds the missing space in the send() info log message, corrects the
stale copy-pasted javadoc on getAlarmTypeFromUEI, and makes the
target wording in the docs and example comment agnostic to whether
the destination path targets a user or a group.
Commit: 6182b206b041eee69a561655c2046abe58b4da6f
https://github.com/OpenNMS/opennms/commit/6182b206b041eee69a561655c2046abe58b4da6f
Author: Marshall Massengill <[email protected]>
Date: 2026-07-29 (Wed, 29 Jul 2026)
Changed paths:
M core/grpc/osgi/pom.xml
M core/ipc/grpc/itests/pom.xml
M core/ipc/rpc/api/src/main/java/org/opennms/core/rpc/api/RpcExceptionUtils.java
M core/ipc/rpc/camel/src/main/java/org/opennms/core/rpc/camel/CamelRpcClientFactory.java
M core/ipc/rpc/camel/src/test/java/org/opennms/core/rpc/camel/LocalRpcTimeoutTest.java
M core/ipc/twin/grpc/itests/pom.xml
M core/ipc/twin/kafka/itests/pom.xml
A core/mate/api/src/main/java/org/opennms/core/mate/api/LazyScope.java
A core/mate/api/src/test/java/org/opennms/core/mate/api/LazyScopeTest.java
M docs/modules/deployment/pages/core/getting-started.adoc
M docs/modules/reference/pages/configuration/ttl-rpc.adoc
M features/collection/client-rpc/src/main/resources/META-INF/opennms/applicationContext-rpc-collector.xml
A features/collection/client-rpc/src/test/java/org/opennms/netmgt/collection/client/rpc/CollectorExecutorLifecycleTest.java
M features/collection/thresholding/impl/src/main/java/org/opennms/netmgt/threshd/ThresholdEntity.java
M features/collection/thresholding/impl/src/main/java/org/opennms/netmgt/threshd/ThresholdingSetImpl.java
M features/collection/thresholding/impl/src/main/java/org/opennms/netmgt/threshd/ThresholdingVisitorImpl.java
M features/minion/core/repository/src/assembly/repo.xml
M features/minion/repository/src/assembly/repo.xml
M features/poller/client-rpc/src/main/java/org/opennms/netmgt/poller/client/rpc/PollerRequestBuilderImpl.java
M features/poller/client-rpc/src/main/resources/META-INF/opennms/applicationContext-rpc-poller.xml
A features/poller/client-rpc/src/test/java/org/opennms/netmgt/poller/client/rpc/PollerExecutorLifecycleTest.java
M features/scv/dominion-grpc-impl/pom.xml
M features/telemetry/protocols/openconfig/itests/pom.xml
M opennms-container/common.mk
M opennms-container/core/Dockerfile
M opennms-container/minion/Dockerfile
M opennms-container/sentinel/Dockerfile
M opennms-provision/opennms-provisiond/src/main/java/org/opennms/netmgt/provision/service/NodeScan.java
M opennms-provision/opennms-provisiond/src/test/java/org/opennms/netmgt/provision/service/ProvisionerIT.java
M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/DiscoveryRestService.java
M opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/DiscoveryRestServiceIT.java
M opennms-webapp/src/main/webapp/WEB-INF/applicationContext-spring-security.xml
M pom.xml
M smoke-test/src/main/java/org/opennms/smoketest/containers/MockCloudContainer.java
M smoke-test/src/main/java/org/opennms/smoketest/selenium/AbstractOpenNMSSeleniumHelper.java
Log Message:
-----------
Merge remote-tracking branch 'upstream/foundation-2024' into mm/NMS-20101-smoke
# Conflicts:
# features/notifications/ticket-strategy/src/test/java/org/opennms/netmgt/notifd/TicketNotificationStrategyTest.java
Commit: 224a50e5ff78c9923bc721d19fa9f9eae48f2b7d
https://github.com/OpenNMS/opennms/commit/224a50e5ff78c9923bc721d19fa9f9eae48f2b7d
Author: Marshall Massengill <[email protected]>
Date: 2026-07-29 (Wed, 29 Jul 2026)
Changed paths:
M docs/modules/operation/pages/deep-dive/notifications/strategies/ticket.adoc
M features/notifications/ticket-strategy/src/main/java/org/opennms/netmgt/notifd/TicketNotificationStrategy.java
M features/notifications/ticket-strategy/src/test/java/org/opennms/netmgt/notifd/TicketNotificationStrategyTest.java
M opennms-base-assembly/src/main/filtered/etc/examples/destinationPaths.xml
Log Message:
-----------
NMS-20101: Skip ticket creation when the alarm already has a ticket
A group destination path target runs the createTicket command once per
member, and repeat notifications or escalations re-run it for the same
alarm; the ticketer creates a new ticket on every create event, so each
run produced another ticket.
Uses the tticketid the strategy already fetches to skip the create
event when the alarm has a ticket. Near-simultaneous deliveries can
still race the asynchronous ticket creation, so the examples and docs
now recommend a single-user target instead of a group.
Commit: bbc2aaf3bbaa2a225ce2337c3880469dc7ff3aed
https://github.com/OpenNMS/opennms/commit/bbc2aaf3bbaa2a225ce2337c3880469dc7ff3aed
Author: Marshall Massengill <[email protected]>
Date: 2026-07-30 (Thu, 30 Jul 2026)
Changed paths:
M docs/modules/operation/pages/deep-dive/notifications/strategies/ticket.adoc
M features/notifications/ticket-strategy/src/main/java/org/opennms/netmgt/notifd/TicketNotificationStrategy.java
M features/notifications/ticket-strategy/src/test/java/org/opennms/netmgt/notifd/TicketNotificationStrategyTest.java
Log Message:
-----------
NMS-20101: Only skip ticket creation while the alarm's ticket is active
Tickets that are closed, resolved, or cancelled, or whose creation
failed, no longer block a new ticket, so a re-fired problem can open a
fresh one. Unknown state values stay on the blocking side, which also
covers a NULL tticketstate reading as 0 (OPEN) through JDBC getInt().
The comparison uses TroubleTicketState.getValue(), which matches the
ordinal the database stores for every current constant.
Allowing a retry after CREATE_FAILED goes beyond the alarmd drools
rules, which only create when the state is null; for a
notification-driven path a failed create should not permanently block
the channel.
Also returns a clean error instead of an NPE when the event row no
longer exists, and adds a point-of-use docs note recommending
single-user targets.
Commit: c91d0b2d953d939daae06e205bcf4710d7543b4e
https://github.com/OpenNMS/opennms/commit/c91d0b2d953d939daae06e205bcf4710d7543b4e
Author: Marshall Massengill <[email protected]>
Date: 2026-07-30 (Thu, 30 Jul 2026)
Changed paths:
M docs/modules/operation/nav.adoc
M docs/modules/operation/pages/deep-dive/notifications/bonus-strategies.adoc
A docs/modules/operation/pages/deep-dive/notifications/strategies/ticket.adoc
M features/notifications/ticket-strategy/src/main/java/org/opennms/netmgt/notifd/TicketNotificationStrategy.java
M features/notifications/ticket-strategy/src/test/java/org/opennms/netmgt/notifd/TicketNotificationStrategyTest.java
M opennms-base-assembly/src/main/filtered/etc/examples/destinationPaths.xml
M opennms-base-assembly/src/main/filtered/etc/examples/notificationCommands.xml
Log Message:
-----------
Merge pull request #8691 from OpenNMS/mm/NMS-20101-smoke
NMS-20101: Make TicketNotificationStrategy usable and document it
Commit: 136b92d401f652793fc6c9d78bd2fbc3cd42381d
https://github.com/OpenNMS/opennms/commit/136b92d401f652793fc6c9d78bd2fbc3cd42381d
Author: Morteza E <[email protected]>
Date: 2026-07-30 (Thu, 30 Jul 2026)
Changed paths:
M docs/modules/operation/nav.adoc
M docs/modules/operation/pages/deep-dive/notifications/bonus-strategies.adoc
A docs/modules/operation/pages/deep-dive/notifications/strategies/ticket.adoc
M features/notifications/ticket-strategy/src/main/java/org/opennms/netmgt/notifd/TicketNotificationStrategy.java
M features/notifications/ticket-strategy/src/test/java/org/opennms/netmgt/notifd/TicketNotificationStrategyTest.java
M opennms-base-assembly/src/main/filtered/etc/examples/destinationPaths.xml
M opennms-base-assembly/src/main/filtered/etc/examples/notificationCommands.xml
Log Message:
-----------
Merge remote-tracking branch 'origin/foundation-2024' into foundation-2025
Commit: 6dae6d8406232ba72c5463fe7245e8e733fded27
https://github.com/OpenNMS/opennms/commit/6dae6d8406232ba72c5463fe7245e8e733fded27
Author: CI/CD System <[email protected]>
Date: 2026-07-30 (Thu, 30 Jul 2026)
Changed paths:
M docs/modules/operation/nav.adoc
M docs/modules/operation/pages/deep-dive/notifications/bonus-strategies.adoc
A docs/modules/operation/pages/deep-dive/notifications/strategies/ticket.adoc
M features/notifications/ticket-strategy/src/main/java/org/opennms/netmgt/notifd/TicketNotificationStrategy.java
M features/notifications/ticket-strategy/src/test/java/org/opennms/netmgt/notifd/TicketNotificationStrategyTest.java
M opennms-base-assembly/src/main/filtered/etc/examples/destinationPaths.xml
M opennms-base-assembly/src/main/filtered/etc/examples/notificationCommands.xml
Log Message:
-----------
Merge remote-tracking branch 'origin/foundation-2025' into release-36.x
Compare: https://github.com/OpenNMS/opennms/compare/7bb6e66d51c3...6dae6d840623
To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications
_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list
To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs