[S] Change in openvpn[master]: verify_x509_name: Improve the error message on failure
"ordex (Code Review)" <[email protected]>
| Newsgroups | gmane.network.openvpn.devel |
|---|---|
| Message-ID | <b1d76cc9ac545b0aa8ddbd2bb826790d38e0f163-EmailReviewComments-HTML@gerrit.openvpn.net> |
Attention is currently required from: plaisthos, selvanair. ordex has posted comments on this change by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1624?usp=email ) Change subject: verify_x509_name: Improve the error message on failure ...................................................................... Patch Set 1: (1 comment) File src/openvpn/ssl_verify.c: http://gerrit.openvpn.net/c/openvpn/+/1624/comment/9a8f2a69_b9100741?usp=email : PS1, Line 397: msg(D_HANDSHAKE, "VERIFY X509NAME OK: %s", subject); by applying the same logic, shouldn't we just print the string we have matched against, instead of the whole subject? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1624?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6e7947ab81cf229f0d27714dd563a07ace6bd38a Gerrit-Change-Number: 1624 Gerrit-PatchSet: 1 Gerrit-Owner: selvanair <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: ordex <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: selvanair <[email protected]> Gerrit-Comment-Date: Mon, 13 Apr 2026 09:16:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel