[S] Change in openvpn[master]: Enable per-socket bind_dev via --local

Attention is currently required from: its_Giaan, plaisthos.

flichtenheld has posted comments on this change by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/1625?usp=email )

Change subject: Enable per-socket bind_dev via --local
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

File doc/man-sections/link-options.rst:

http://gerrit.openvpn.net/c/openvpn/+/1625/comment/15733805_d4bc2521?usp=email :
PS1, Line 114:      local host|* [port] [protocol] [bind device]
Should also add a reference to `--bind-dev` somewhere in the documentation below. I realize we do not have corresponding references for `port` and `protocol` either, but maybe we can also fix that?


File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/1625/comment/d6b4199e_963ab8ae?usp=email :
PS1, Line 6010:             msg(M_WARN | M_ERRNO, "Note: bind_dev is ignored on non-Linux systems");
No syscalls involved here, so M_ERRNO makes no sense


http://gerrit.openvpn.net/c/openvpn/+/1625/comment/b13fa4de_a8359f50?usp=email :
PS1, Line 6541: #if defined(TARGET_LINUX)
Why this random change?


File src/openvpn/socket.c:

http://gerrit.openvpn.net/c/openvpn/+/1625/comment/90dda228_fbf9b24f?usp=email :
PS1, Line 1413:     /* bind_dev from local_list will trump on the global option. */
Remove "on", remove the trailing full stop



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1625?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6319c951327a9b994ffae0ba35270b0887455203
Gerrit-Change-Number: 1625
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: its_Giaan <[email protected]>
Gerrit-Comment-Date: Mon, 13 Apr 2026 11:20:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel