[S] Change in openvpn[master]: Enable per-socket bind_dev via --local

Attention is currently required from: flichtenheld, plaisthos.

its_Giaan has posted comments on this change by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/1625?usp=email )

Change subject: Enable per-socket bind_dev via --local
......................................................................


Patch Set 2:

(4 comments)

File doc/man-sections/link-options.rst:

http://gerrit.openvpn.net/c/openvpn/+/1625/comment/deef9428_ebae9b5d?usp=email :
PS1, Line 114:      local host|* [port] [protocol] [bind device]
> Should also add a reference to `--bind-dev` somewhere in the documentation below. […]
I did it only for --bind-dev at the moment, if you're fine with that will do the same way for --port and --proto in a different patch.


File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/1625/comment/63bf8009_24bcad5f?usp=email :
PS1, Line 6010:             msg(M_WARN | M_ERRNO, "Note: bind_dev is ignored on non-Linux systems");
> No syscalls involved here, so M_ERRNO makes no sense
Done


http://gerrit.openvpn.net/c/openvpn/+/1625/comment/d7b038f0_ac763769?usp=email :
PS1, Line 6541: #if defined(TARGET_LINUX)
> Why this random change?
Just a leftover, initially this patch also aimed to enable bind-dev for freebsd, then I decided to do that in a different patch.


File src/openvpn/socket.c:

http://gerrit.openvpn.net/c/openvpn/+/1625/comment/cf628b0d_3b3678c2?usp=email :
PS1, Line 1413:     /* bind_dev from local_list will trump on the global option. */
> Remove "on", remove the trailing full stop
Done



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1625?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6319c951327a9b994ffae0ba35270b0887455203
Gerrit-Change-Number: 1625
Gerrit-PatchSet: 2
Gerrit-Owner: its_Giaan <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Mon, 13 Apr 2026 15:20:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel