[S] Change in openvpn[master]: verify_x509_name: Improve the error message on failure

Attention is currently required from: ordex, plaisthos.

selvanair has posted comments on this change by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1624?usp=email )

Change subject: verify_x509_name: Improve the error message on failure
......................................................................


Patch Set 1:

(1 comment)

File src/openvpn/ssl_verify.c:

http://gerrit.openvpn.net/c/openvpn/+/1624/comment/b73b8520_97809e57?usp=email :
PS1, Line 397:         msg(D_HANDSHAKE, "VERIFY X509NAME OK: %s", subject);
> by applying the same logic, shouldn't we just print the string we have matched against, instead of t […]
Here is my thought on this:
On success, its just a gratuitous message and its not confusing. We are just printing what the subject (DN) of the certificate is.
On error, its a critical message that says what was expected and what was found. The current code tries to match something and prints something else.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1624?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6e7947ab81cf229f0d27714dd563a07ace6bd38a
Gerrit-Change-Number: 1624
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: ordex <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: ordex <[email protected]>
Gerrit-Comment-Date: Mon, 13 Apr 2026 17:23:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel