[M] Change in openvpn[master]: multipeer: introduce asymmetric peer-id

Attention is currently required from: its_Giaan.

flichtenheld has posted comments on this change by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/1089?usp=email )

Change subject: multipeer: introduce asymmetric peer-id
......................................................................


Patch Set 16: Code-Review-1

(4 comments)

File src/openvpn/multi.c:

http://gerrit.openvpn.net/c/openvpn/+/1089/comment/4cc88294_1a96a5b5?usp=email :
PS16, Line 1729: 
spurious change


File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/1089/comment/a92aab4d_80a8d40f?usp=email :
PS16, Line 3890: 
spurious change


File src/openvpn/ssl.c:

http://gerrit.openvpn.net/c/openvpn/+/1089/comment/92521dd9_9d09e7d5?usp=email :
PS16, Line 2347:         free(multi->peer_info);
useless free, we know it is NULL


http://gerrit.openvpn.net/c/openvpn/+/1089/comment/0dbe9a30_4550caf1?usp=email :
PS16, Line 2348:         multi->peer_info = read_string_alloc(buf);
This needs a comment. Why if we do not find a peer_info, we just try again? Where does the empty string come from? And why does the MODE_SERVER code only use the first one while the MODE_POINT_TO_POINT code is happy to use either?



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1089?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0a13ee90b6706acf20eabcee3bab3f2dff639bf9
Gerrit-Change-Number: 1089
Gerrit-PatchSet: 16
Gerrit-Owner: its_Giaan <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: its_Giaan <[email protected]>
Gerrit-Comment-Date: Wed, 24 Jun 2026 13:31:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel