[M] Change in openvpn[master]: Support p2p NCP negotiation in p2mp mode

Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1719?usp=email )

Change subject: Support p2p NCP negotiation in p2mp mode
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/1719/comment/12a6b108_2c37c3f3?usp=email :
PS2, Line 10: detected. This is currently make little difference as peer-id/DATAv2 does
"makes"


File src/openvpn/ssl.c:

http://gerrit.openvpn.net/c/openvpn/+/1719/comment/4a09bf76_44215984?usp=email :
PS2, Line 2339:                 /* If the peer is using NCP P2P we also use p2p to make connecting
How is enabling sending peer_info "using p2p"? This comment doesn't make sense to me.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1719?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I8f3545f703126dbe96f809e69ad351749b14b1e1
Gerrit-Change-Number: 1719
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Wed, 24 Jun 2026 14:21:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel