[M] Change in openvpn[master]: oob: Add client PROBE_REPLY parser

Attention is currently required from: flichtenheld, stipa.

plaisthos has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1745?usp=email )

Change subject: oob: Add client PROBE_REPLY parser
......................................................................


Patch Set 8: Code-Review-1

(4 comments)

File src/openvpn/oob.c:

http://gerrit.openvpn.net/c/openvpn/+/1745/comment/44ce705a_e1b25856?usp=email :
PS8, Line 191:         }
In the happy case we do not check that the length is valid and inside the buffer


http://gerrit.openvpn.net/c/openvpn/+/1745/comment/82a7b47d_f8e4d6de?usp=email :
PS8, Line 196:         }
for the other case we check this.


http://gerrit.openvpn.net/c/openvpn/+/1745/comment/80a327f4_450b8ad1?usp=email :
PS8, Line 198:     return false;
Can we have nicer formatting of methods? I find this style of everything squished together not great to read.


http://gerrit.openvpn.net/c/openvpn/+/1745/comment/89434ef2_3db2521a?usp=email :
PS8, Line 207:            && oob_probe_parameter_read(payload, param, value_len);
I am just at this and I wonder if we can improve the code.

This API/function does not look particular great if this the way we have to interact with it. This is not a very readable method to me.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1745?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If04ce09d4c353f5384c0c48f48f63e05869a373f
Gerrit-Change-Number: 1745
Gerrit-PatchSet: 8
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Attention: stipa <[email protected]>
Gerrit-Comment-Date: Sun, 26 Jul 2026 01:20:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel