[L] Change in openvpn[master]: oob: Add probe-result ranking for server selection

Attention is currently required from: stipa.

plaisthos has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1746?usp=email )

Change subject: oob: Add probe-result ranking for server selection
......................................................................


Patch Set 9:

(1 comment)

File src/openvpn/oob.c:

http://gerrit.openvpn.net/c/openvpn/+/1746/comment/9ed728f8_d40ffac7?usp=email :
PS9, Line 268:     if (ra->responded)
I think if you started with 

if (ra->responsed && rb->responded)

and make the logic and intent of the sorting would be more clear instead of this double negative logic here the function would be much easier to read and understand.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1746?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I55da68cc341bcfc707fd34ca2f84ff9b6a55501f
Gerrit-Change-Number: 1746
Gerrit-PatchSet: 9
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: stipa <[email protected]>
Gerrit-Comment-Date: Sun, 26 Jul 2026 01:25:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel