[M] Change in openvpn[master]: oob: client handshake shortcut via a server probe

Attention is currently required from: stipa.

plaisthos has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1770?usp=email )

Change subject: oob: client handshake shortcut via a server probe
......................................................................


Patch Set 8: Code-Review-1

(3 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/1770/comment/8e001067_ef9168f5?usp=email :
PS8, Line 7: oob: client handshake shortcut via a server probe
I don't think handshake shortcut is a good name here. Because that is not what this is really this. 

We are not short cutting anything here. We are doing a normal server connection with a slightly different packets at the start.


File Changes.rst:

http://gerrit.openvpn.net/c/openvpn/+/1770/comment/7acec7dc_b19b4484?usp=email :
PS8, Line 15:     for it. This needs no extra configuration.
there is no skipping of a round of three-way handshake. The probe packet is just a replacement for the RESET_V3/RESET_V2 packet.

This change entry is misleading.


File src/openvpn/oob_client.c:

http://gerrit.openvpn.net/c/openvpn/+/1770/comment/a8368f3e_fcf6298a?usp=email :
PS8, Line 657:      * immediately before connecting (~0 s gap), so that check is a no-op today;
You can probe two server and then both reply and then the you don't connect to both of them instantly. And when you reach the second server there is more than a 0s gap.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1770?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I454d5040cbad4d373ee4f90b8d683200d2a4c0e4
Gerrit-Change-Number: 1770
Gerrit-PatchSet: 8
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: stipa <[email protected]>
Gerrit-Comment-Date: Sun, 26 Jul 2026 01:55:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel