[M] Change in openvpn[master]: oob: Unwrap tls-crypt-v2 server probes (P_CONTROL_OOB_WKC_V1)

Attention is currently required from: stipa.

plaisthos has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1758?usp=email )

Change subject: oob: Unwrap tls-crypt-v2 server probes (P_CONTROL_OOB_WKC_V1)
......................................................................


Patch Set 10: Code-Review-1

(2 comments)

File src/openvpn/ssl_pkt.h:

http://gerrit.openvpn.net/c/openvpn/+/1758/comment/b7142585_2069b9b1?usp=email :
PS10, Line 79:  * protocol (CONTROL_OOB_WKC_V1). */
This apparently is also not a legal op code since P_LAST_OPCODE was not touched.


File src/openvpn/ssl_pkt.c:

http://gerrit.openvpn.net/c/openvpn/+/1758/comment/3ee5b5b2_be65af43?usp=email :
PS10, Line 400:         return VERDICT_VALID_OOB_V1;
Either have VERDICT_VALID_OOB_WKC_V1 or also have categories/consolidate some of the other enums together as well but this way it is very inconsistent. That you have to write a long comment to justify that inconsistency proves the point.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1758?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Idb8c0c660a98de8ec549b69f6692a7b41b092eaf
Gerrit-Change-Number: 1758
Gerrit-PatchSet: 10
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: stipa <[email protected]>
Gerrit-Comment-Date: Sun, 26 Jul 2026 02:06:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel