[M] Change in openvpn[master]: Change hash iv to a be a fixed sized array
"flichtenheld \(Code Review\) via Openvpn-devel" <[email protected]> Thu, 30 Jul 2026 09:28:38 +0000
| Newsgroups | gmane.network.openvpn.devel |
|---|---|
| Message-ID | <5c0d6c2283e109295c6e3dfc6530aadf57bbe736-EmailReviewComments-HTML@gerrit.openvpn.net> |
--===============3622847466081035770== Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="HzYvIYcmAGg="; charset=UTF-8 --HzYvIYcmAGg= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos=2E flichtenheld has posted= comments on this change by plaisthos=2E ( http://gerrit=2Eopenvpn=2Enet/c/= openvpn/+/1571?usp=3Demail ) Change subject: Change hash iv to a be a fixe= d sized array =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= Patch Set 20: Code-Review+2 (2 comments) File src/openvpn/list=2Ec: h= ttp://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1571/comment/8f17200a_f4d143cb?usp= =3Demail : PS19, Line 425: hash_func_new_ctx(void) > forgot to remove? Done= File src/openvpn/multi=2Ec: http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1= 571/comment/ee868554_f789ca22?usp=3Demail : PS19, Line 313: * value an= d function for the context parameters=2E > comment is obsolete Done -- = To view, visit http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1571?usp=3Demail T= o unsubscribe, or for help writing mail filters, visit http://gerrit=2Eopen= vpn=2Enet/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project:= openvpn Gerrit-Branch: master Gerrit-Change-Id: If47c7d920b2fa4047b7db03fc= de821899839324d Gerrit-Change-Number: 1571 Gerrit-PatchSet: 20 Gerrit-Owner= : plaisthos <arne-openvpn@rfc2549=2Eorg> Gerrit-Reviewer: flichtenheld <fra= nk@lichtenheld=2Ecom> Gerrit-CC: openvpn-devel <openvpn-devel@lists=2Esourc= eforge=2Enet> Gerrit-Attention: plaisthos <arne-openvpn@rfc2549=2Eorg> Gerr= it-Comment-Date: Thu, 30 Jul 2026 09:28:38 +0000 Gerrit-HasComments: Yes Ge= rrit-Has-Labels: Yes Comment-In-Reply-To: flichtenheld <frank@lichtenheld= =2Ecom> --HzYvIYcmAGg= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html><html><head><style></style></head><body><p> Attention is cur= rently required from: plaisthos=2E </p> <p>Patch set 20:<span style=3D"bord= er-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;backgrou= nd-color: #d4ffd4;">Code-Review +2</span></p><p><a href=3D"http://gerrit=2E= openvpn=2Enet/c/openvpn/+/1571?usp=3Demail">View Change</a></p><p>2 comment= s:</p><ul style=3D"list-style: none; padding: 0;"><li style=3D"margin: 0; p= adding: 0;"><p>File src/openvpn/list=2Ec:</p><ul style=3D"list-style: none;= padding: 0;"><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"mar= gin-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1571= /comment/8f17200a_f4d143cb?usp=3Demail">Patch Set #19, Line 425:</a> <code = style=3D"font-family:monospace,monospace">hash_func_new_ctx(void)</code></p= ><p><blockquote style=3D"border-left: 1px solid #aaa; margin: 10px 0; paddi= ng: 0 10px;">forgot to remove?</blockquote></p><p class=3D"blocks" style=3D= "white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li = style=3D"margin: 0; padding: 0;"><p>File src/openvpn/multi=2Ec:</p><ul styl= e=3D"list-style: none; padding: 0;"><li style=3D"margin: 0; padding: 0 0 0 = 16px;"><p style=3D"margin-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn= =2Enet/c/openvpn/+/1571/comment/ee868554_f789ca22?usp=3Demail">Patch Set #1= 9, Line 313:</a> <code style=3D"font-family:monospace,monospace"> * val= ue and function for the context parameters=2E</code></p><p><blockquote styl= e=3D"border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">comment= is obsolete</blockquote></p><p class=3D"blocks" style=3D"white-space: pre-= wrap; word-wrap: break-word;">Done</p></li></ul></li></ul><p>To view, visit= <a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1571?usp=3Demail">cha= nge 1571</a>=2E To unsubscribe, or for help writing mail filters, visit <a = href=3D"http://gerrit=2Eopenvpn=2Enet/settings?usp=3Demail">settings</a>=2E= </p><div itemscope itemtype=3D"http://schema=2Eorg/EmailMessage"><div items= cope itemprop=3D"action" itemtype=3D"http://schema=2Eorg/ViewAction"><link = itemprop=3D"url" href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1571?usp= =3Demail"/><meta itemprop=3D"name" content=3D"View Change"/></div></div> <= div style=3D"display:none"> Gerrit-MessageType: comment </div> <div style= =3D"display:none"> Gerrit-Project: openvpn </div> <div style=3D"display:non= e"> Gerrit-Branch: master </div> <div style=3D"display:none"> Gerrit-Change= -Id: If47c7d920b2fa4047b7db03fcde821899839324d </div> <div style=3D"display= :none"> Gerrit-Change-Number: 1571 </div> <div style=3D"display:none"> Gerr= it-PatchSet: 20 </div> <div style=3D"display:none"> Gerrit-Owner: plaisthos= <arne-openvpn@rfc2549=2Eorg> </div> <div style=3D"display:none"> Ger= rit-Reviewer: flichtenheld <frank@lichtenheld=2Ecom> </div> <div styl= e=3D"display:none"> Gerrit-CC: openvpn-devel <openvpn-devel@lists=2Esour= ceforge=2Enet> </div> <div style=3D"display:none"> Gerrit-Attention: pla= isthos <arne-openvpn@rfc2549=2Eorg> </div> <div style=3D"display:none= "> Gerrit-Comment-Date: Thu, 30 Jul 2026 09:28:38 +0000 </div> <div style= =3D"display:none"> Gerrit-HasComments: Yes </div> <div style=3D"display:non= e"> Gerrit-Has-Labels: Yes </div> <div style=3D"display:none"> Comment-In-R= eply-To: flichtenheld <frank@lichtenheld=2Ecom> </div> </body></html= > --HzYvIYcmAGg=-- --===============3622847466081035770== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============3622847466081035770== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel --===============3622847466081035770==--