[L] Change in openvpn[master]: Use OpenSSL's SIPHASH implementation to double check our implementation
"flichtenheld \(Code Review\) via Openvpn-devel" <[email protected]> Thu, 30 Jul 2026 10:08:33 +0000
| Newsgroups | gmane.network.openvpn.devel |
|---|---|
| Message-ID | <e23aa45088b20d122e6b6703acdc1b68dae5e3d7-EmailReviewComments-HTML@gerrit.openvpn.net> |
--===============5246065052565103283== Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="63ZmMWeVJOM="; charset=UTF-8 --63ZmMWeVJOM= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos=2E flichtenheld has posted= comments on this change by plaisthos=2E ( http://gerrit=2Eopenvpn=2Enet/c/= openvpn/+/31?usp=3Demail ) Change subject: Use OpenSSL's SIPHASH implement= ation to double check our implementation =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E Patch Set 28: Code-Review-1 (5 comments) Pa= tchset: PS20: > I changed the commit to only double our implement (or AWS= LC) and also removed the whole context stu [=E2=80=A6] Acknowledged File= CMakeLists=2Etxt: http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/31/comment/7c= 17fa3c_8c8925c9?usp=3Demail : PS28, Line 801: target_compile_definition= s(test_crypto PRIVATE PREFER_OPENSSL_SIPHASH) Does this still do anything? = File tests/unit_tests/openvpn/Makefile=2Eam: http://gerrit=2Eopenvpn=2En= et/c/openvpn/+/31/comment/e3e08277_ebd09952?usp=3Demail : PS28, Line 102: = -DPREFER_OPENSSL_SIPHASH \ Does this still do anything? File tests/unit_t= ests/openvpn/siphash_openssl=2Eh: http://gerrit=2Eopenvpn=2Enet/c/openvpn/= +/31/comment/3f47a563_e861ae7d?usp=3Demail : PS28, Line 2: * SipHash refer= ence C implementation Wrong copyright header File tests/unit_tests/openvp= n/siphash_openssl=2Ec: http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/31/commen= t/54f0abd7_e9a26545?usp=3Demail : PS28, Line 35: * implementation, so we o= nly use for unit testing that our impelmentation "use it" "implementation" = -- To view, visit http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/31?usp=3Dem= ail To unsubscribe, or for help writing mail filters, visit http://gerrit= =2Eopenvpn=2Enet/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-P= roject: openvpn Gerrit-Branch: master Gerrit-Change-Id: I09aa27caa1a3aab0d1= be6118b26d54a1c1bf7aa0 Gerrit-Change-Number: 31 Gerrit-PatchSet: 28 Gerrit-= Owner: plaisthos <arne-openvpn@rfc2549=2Eorg> Gerrit-Reviewer: flichtenheld= <frank@lichtenheld=2Ecom> Gerrit-CC: openvpn-devel <openvpn-devel@lists=2E= sourceforge=2Enet> Gerrit-Attention: plaisthos <arne-openvpn@rfc2549=2Eorg>= Gerrit-Comment-Date: Thu, 30 Jul 2026 10:08:33 +0000 Gerrit-HasComments: Y= es Gerrit-Has-Labels: Yes Comment-In-Reply-To: plaisthos <arne-openvpn@rfc2= 549=2Eorg> Comment-In-Reply-To: flichtenheld <frank@lichtenheld=2Ecom> --63ZmMWeVJOM= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html><html><head><style></style></head><body><p> Attention is cur= rently required from: plaisthos=2E </p> <p>Patch set 28:<span style=3D"bord= er-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;backgrou= nd-color: #ffd4d4;">Code-Review -1</span></p><p><a href=3D"http://gerrit=2E= openvpn=2Enet/c/openvpn/+/31?usp=3Demail">View Change</a></p><p>5 comments:= </p><ul style=3D"list-style: none; padding: 0;"><li style=3D"margin: 0; pad= ding: 0;"><p>Patchset:</p><ul style=3D"list-style: none; padding: 0;"><li s= tyle=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"margin-bottom: 4px;"><= a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/31?tab=3Dcomments&u= sp=3Demail">Patch Set #20:</a> </p><p><blockquote style=3D"border-left: 1px= solid #aaa; margin: 10px 0; padding: 0 10px;">I changed the commit to only= double our implement (or AWS LC) and also removed the whole context stu [= =E2=80=A6]</blockquote></p><p class=3D"blocks" style=3D"white-space: pre-wr= ap; word-wrap: break-word;">Acknowledged</p></li></ul></li><li style=3D"mar= gin: 0; padding: 0;"><p>File CMakeLists=2Etxt:</p><ul style=3D"list-style: = none; padding: 0;"><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style= =3D"margin-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn= /+/31/comment/7c17fa3c_8c8925c9?usp=3Demail">Patch Set #28, Line 801:</a> <= code style=3D"font-family:monospace,monospace"> target_compile_definitio= ns(test_crypto PRIVATE PREFER_OPENSSL_SIPHASH)</code></p><p class=3D"blocks= " style=3D"white-space: pre-wrap; word-wrap: break-word;">Does this still d= o anything?</p></li></ul></li><li style=3D"margin: 0; padding: 0;"><p>File = tests/unit_tests/openvpn/Makefile=2Eam:</p><ul style=3D"list-style: none; p= adding: 0;"><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"margi= n-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/31/com= ment/e3e08277_ebd09952?usp=3Demail">Patch Set #28, Line 102:</a> <code styl= e=3D"font-family:monospace,monospace"> -DPREFER_OPENSSL_SIPHASH \</code></p= ><p class=3D"blocks" style=3D"white-space: pre-wrap; word-wrap: break-word;= ">Does this still do anything?</p></li></ul></li><li style=3D"margin: 0; pa= dding: 0;"><p>File tests/unit_tests/openvpn/siphash_openssl=2Eh:</p><ul sty= le=3D"list-style: none; padding: 0;"><li style=3D"margin: 0; padding: 0 0 0= 16px;"><p style=3D"margin-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn= =2Enet/c/openvpn/+/31/comment/3f47a563_e861ae7d?usp=3Demail">Patch Set #28,= Line 2:</a> <code style=3D"font-family:monospace,monospace"> * SipHash ref= erence C implementation</code></p><p class=3D"blocks" style=3D"white-space:= pre-wrap; word-wrap: break-word;">Wrong copyright header</p></li></ul></li= ><li style=3D"margin: 0; padding: 0;"><p>File tests/unit_tests/openvpn/siph= ash_openssl=2Ec:</p><ul style=3D"list-style: none; padding: 0;"><li style= =3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"margin-bottom: 4px;"><a hr= ef=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/31/comment/54f0abd7_e9a2654= 5?usp=3Demail">Patch Set #28, Line 35:</a> <code style=3D"font-family:monos= pace,monospace"> * implementation, so we only use for unit testing that our= impelmentation</code></p><p class=3D"blocks" style=3D"white-space: pre-wra= p; word-wrap: break-word;">"use it"<br>"implementation"= </p></li></ul></li></ul><p>To view, visit <a href=3D"http://gerrit=2Eopenvp= n=2Enet/c/openvpn/+/31?usp=3Demail">change 31</a>=2E To unsubscribe, or for= help writing mail filters, visit <a href=3D"http://gerrit=2Eopenvpn=2Enet/= settings?usp=3Demail">settings</a>=2E</p><div itemscope itemtype=3D"http://= schema=2Eorg/EmailMessage"><div itemscope itemprop=3D"action" itemtype=3D"h= ttp://schema=2Eorg/ViewAction"><link itemprop=3D"url" href=3D"http://gerrit= =2Eopenvpn=2Enet/c/openvpn/+/31?usp=3Demail"/><meta itemprop=3D"name" conte= nt=3D"View Change"/></div></div> <div style=3D"display:none"> Gerrit-Messa= geType: comment </div> <div style=3D"display:none"> Gerrit-Project: openvpn= </div> <div style=3D"display:none"> Gerrit-Branch: master </div> <div styl= e=3D"display:none"> Gerrit-Change-Id: I09aa27caa1a3aab0d1be6118b26d54a1c1bf= 7aa0 </div> <div style=3D"display:none"> Gerrit-Change-Number: 31 </div> <d= iv style=3D"display:none"> Gerrit-PatchSet: 28 </div> <div style=3D"display= :none"> Gerrit-Owner: plaisthos <arne-openvpn@rfc2549=2Eorg> </div> <= div style=3D"display:none"> Gerrit-Reviewer: flichtenheld <frank@lichten= held=2Ecom> </div> <div style=3D"display:none"> Gerrit-CC: openvpn-devel= <openvpn-devel@lists=2Esourceforge=2Enet> </div> <div style=3D"displ= ay:none"> Gerrit-Attention: plaisthos <arne-openvpn@rfc2549=2Eorg> </= div> <div style=3D"display:none"> Gerrit-Comment-Date: Thu, 30 Jul 2026 10:= 08:33 +0000 </div> <div style=3D"display:none"> Gerrit-HasComments: Yes </d= iv> <div style=3D"display:none"> Gerrit-Has-Labels: Yes </div> <div style= =3D"display:none"> Comment-In-Reply-To: plaisthos <arne-openvpn@rfc2549= =2Eorg> </div> <div style=3D"display:none"> Comment-In-Reply-To: flichte= nheld <frank@lichtenheld=2Ecom> </div> </body></html> --63ZmMWeVJOM=-- --===============5246065052565103283== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============5246065052565103283== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel --===============5246065052565103283==--