[S] Change in openvpn[master]: Introduce get_key_by_management_key_id helper function

Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1856?usp=email )

Change subject: Introduce get_key_by_management_key_id helper function
......................................................................


Patch Set 6: Code-Review-1

(2 comments)

File src/openvpn/ssl_common.h:

http://gerrit.openvpn.net/c/openvpn/+/1856/comment/e8a69349_62952bb7?usp=email :
PS6, Line 764:  * Gets the \c key_state  object that belong to the management key id or
"belongs"


http://gerrit.openvpn.net/c/openvpn/+/1856/comment/fef06de2_4e158fa9?usp=email :
PS6, Line 775:             return ks;
The old code did not abort on first match but always checked all three key states. Is there some state where this might make a difference?



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1856?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I42d8785959c24bf688190965e58b9b98251b8557
Gerrit-Change-Number: 1856
Gerrit-PatchSet: 6
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Wed, 26 Aug 2026 12:58:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel