[XL] Change in openvpn[master]: Implement sending/receiving app custom control protocol

Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1858?usp=email )

Change subject: Implement sending/receiving app custom control protocol
......................................................................


Patch Set 7: Code-Review-1

(6 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/1858/comment/24794c39_d6c4cd0c?usp=email :
PS7, Line 8: 
Should probably have a more informative commit message...


File doc/management-notes.txt:

http://gerrit.openvpn.net/c/openvpn/+/1858/comment/581a5093_d86412d3?usp=email :
PS7, Line 804: the common app custom protocols between the client and the sever and insruct
"instruct"


http://gerrit.openvpn.net/c/openvpn/+/1858/comment/6b2bd590_3c14cc8c?usp=email :
PS7, Line 814: This commands sends an app custom control message to a client,
"command"


http://gerrit.openvpn.net/c/openvpn/+/1858/comment/9e7ad244_cf52deae?usp=email :
PS7, Line 829: flags    -- a colon seperated list of the encoding and the flag if
"separated"


http://gerrit.openvpn.net/c/openvpn/+/1858/comment/5defbc51_afbedab4?usp=email :
PS7, Line 839: This commands sends an app custom command to the peer, the format of the
"command"


http://gerrit.openvpn.net/c/openvpn/+/1858/comment/2746ddcc_8b99b4c9?usp=email :
PS7, Line 839: This commands sends an app custom command to the peer, the format of the
It is not directly clear to me why we have two separate commands here? One if for P2MP and the other for P2P? Or something else?



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1858?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4a6a6ef41e15896b8b79d795b2a6de86b8ae4c84
Gerrit-Change-Number: 1858
Gerrit-PatchSet: 7
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Wed, 26 Aug 2026 13:23:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel