Re: [PATCH v2] networking_sitnl: validate netlink replies against the request
Antonio Quartulli <[email protected]>
| Newsgroups | gmane.network.openvpn.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi, On 01/09/2026 09:58, Gert Doering wrote: > From: Antonio Quartulli <[email protected]> > > sitnl_send() passed every well-formed reply to the callback without > checking it matched the outstanding request: the seq/pid check was > commented out and the sequence number came from time(NULL). > > Seed a monotonically increasing sequence number and drop any message > that is not from the kernel (nl_pid 0) or does not echo our port id and > sequence number. > > Change-Id: Ie7352dd136cccda2bd6b6e1a36db1a5f27afd8f7 > GitHub: fixes OpenVPN/openvpn-private-issues#9 > Signed-off-by: Antonio Quartulli <[email protected]> > Acked-by: Ralf Lici <[email protected]> > Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1782 I forgot to add the tag, but this patch was Reported-by: Joshua Rogers <[email protected]> -- Antonio Quartulli