[M] Change in openvpn[master]: Support pre-existing Linux DCO interfaces

"ordex \(Code Review\) via Openvpn-devel" <[email protected]>
Newsgroups gmane.network.openvpn.devel
Message-ID <1d73bd8cfd1d94bdfa9c9698e32b6add40e26d90-EmailReviewComments-HTML@gerrit.openvpn.net>
Attention is currently required from: plaisthos, ralf_lici.

ordex has posted comments on this change by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/1734?usp=email )

Change subject: Support pre-existing Linux DCO interfaces
......................................................................


Patch Set 1:

(2 comments)

File src/openvpn/dco_linux.c:

http://gerrit.openvpn.net/c/openvpn/+/1734/comment/a605f1be_6b97fa8b?usp=email :
PS1, Line 516:     else if (ret == -EEXIST)
else not needed. Previous branch has a return (easier on my brain too)


http://gerrit.openvpn.net/c/openvpn/+/1734/comment/30d0fd8d_7f0291c2?usp=email :
PS1, Line 518:         const char *expected = tt->dco.ifmode == OVPN_MODE_MP ? "server" : "p2p";
move this only inside the if-block where we use it



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1734?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I72302403bddee4b0b0ee2441ae9e246f48d0bc81
Gerrit-Change-Number: 1734
Gerrit-PatchSet: 1
Gerrit-Owner: ralf_lici <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: ordex <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: ralf_lici <[email protected]>
Gerrit-Comment-Date: Thu, 03 Sep 2026 14:00:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.