[M] Change in openvpn[master]: Support pre-existing Linux DCO interfaces

Attention is currently required from: ordex, plaisthos.

ralf_lici has posted comments on this change by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/1734?usp=email )

Change subject: Support pre-existing Linux DCO interfaces
......................................................................


Patch Set 1:

(3 comments)

File src/openvpn/dco_linux.c:

http://gerrit.openvpn.net/c/openvpn/+/1734/comment/0d2aac5f_5d49223f?usp=email :
PS1, Line 516:     else if (ret == -EEXIST)
> else not needed. […]
The else branch is actually needed because ret could also be 0 so this portion of the code has to execute only when there's a pre-existing inteface available. If we remove the else branch and execute unconditionally we'd query the just created interface, which should work but is not really useful.


http://gerrit.openvpn.net/c/openvpn/+/1734/comment/3e85b0cf_71e2304b?usp=email :
PS1, Line 518:         const char *expected = tt->dco.ifmode == OVPN_MODE_MP ? "server" : "p2p";
> move this only inside the if-block where we use it
Acknowledged


http://gerrit.openvpn.net/c/openvpn/+/1734/comment/b853ea66_9f7911b6?usp=email :
PS1, Line 520:         int mode_ret = net_iface_ovpn_mode(ctx, dev, &mode);
> how about moving the (re)definition of `enum ovpn_mode` (and its ifla friends) to networking_sitnl. […]
Acknowledged



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1734?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I72302403bddee4b0b0ee2441ae9e246f48d0bc81
Gerrit-Change-Number: 1734
Gerrit-PatchSet: 1
Gerrit-Owner: ralf_lici <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: ordex <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: ordex <[email protected]>
Gerrit-Comment-Date: Thu, 03 Sep 2026 15:07:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel