[M] Change in openvpn[release/2.7]: Check for null-bytes in certificate subjects
"MaxF \(Code Review\) via Openvpn-devel" <[email protected]>
| Newsgroups | gmane.network.openvpn.devel |
|---|---|
| Message-ID | <c1ae08a821712faa72373048af254765d7653b39-EmailReviewComments-HTML@gerrit.openvpn.net> |
Attention is currently required from: plaisthos, syzzer. MaxF has posted comments on this change by MaxF. ( http://gerrit.openvpn.net/c/openvpn/+/1902?usp=email ) Change subject: Check for null-bytes in certificate subjects ...................................................................... Patch Set 1: (1 comment) File src/openvpn/ssl_verify_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1902/comment/ff834928_84e03501?usp=email : PS1, Line 389: | ASN1_STRFLGS_ESC_CTRL); > Why remove the ESC_CTRL? I did the same thing in the master branch. This flag was escaping null bytes to '\\0', so the check after it wouldn't work. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1902?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: release/2.7 Gerrit-Change-Id: Iea1481e94ba1abe18c39d81cd797187c88427571 Gerrit-Change-Number: 1902 Gerrit-PatchSet: 1 Gerrit-Owner: MaxF <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: syzzer <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: syzzer <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Mon, 07 Sep 2026 12:54:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: syzzer <[email protected]> _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel