[M] Change in openvpn[release/2.7]: Check for null-bytes in certificate subjects

Attention is currently required from: MaxF, plaisthos.

syzzer has posted comments on this change by MaxF. ( http://gerrit.openvpn.net/c/openvpn/+/1902?usp=email )

Change subject: Check for null-bytes in certificate subjects
......................................................................


Patch Set 1:

(1 comment)

File src/openvpn/ssl_verify_openssl.c:

http://gerrit.openvpn.net/c/openvpn/+/1902/comment/f93e7c60_473c2dec?usp=email :
PS1, Line 389:                            | ASN1_STRFLGS_ESC_CTRL);
> I did the same thing in the master branch. […]
Hmm, but that still changes user-visible behavior, since we now no longer escape all the other control characters. Maybe we need two print_ex calls: one to check for null-bytes and one for actually printing the subject.

For master I seem to have missed there are two closely related escape names: ASN1_STRFLGS_RFC2253 and ASN1_STRFLGS_ESC_2253. I thought you used the RFC2253 one, which also includes ESC_CTRL... Which makes me wonder, shouldn't we use the RFC2253 one for the actual printing (and also have one extra just for checking for nul-bytes)?



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1902?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: release/2.7
Gerrit-Change-Id: Iea1481e94ba1abe18c39d81cd797187c88427571
Gerrit-Change-Number: 1902
Gerrit-PatchSet: 1
Gerrit-Owner: MaxF <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-Reviewer: syzzer <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: MaxF <[email protected]>
Gerrit-Comment-Date: Mon, 07 Sep 2026 13:46:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: syzzer <[email protected]>
Comment-In-Reply-To: MaxF <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel